Decouple harvest model from the rest of the plugin

Separate HarvestMetadataAPIPlugin to its own module, update imports on
CLI commands. This CLI would be better off in a separate plugin but we
don't want to add more complexity and keep compatibility

Author: amercader

ckanext/spatial/cli.py

@@ -1,7 +1,6 @@
 # encoding: utf-8
 import click
 
-import ckanext.spatial.util as util
 
 
 def get_commands():
@@ -22,8 +21,8 @@ def report(pkg):
     Performs validation on the harvested metadata, either for all
     packages or the one specified.
     """
-
-    return util.report(pkg)
+    from ckanext.spatial.util import report
+    return report(pkg)
 
 
 @spatial_validation.command('report-csv')
@@ -33,11 +32,13 @@ def report_csv(filepath):
     Performs validation on all the harvested metadata in the db and
     writes a report in CSV format to the given filepath.
     """
-    return util.report_csv(filepath)
+    from ckanext.spatial.util import report_csv
+    return report_csv(filepath)
 
 
 @spatial_validation.command('file')
 @click.argument('filepath')
 def validate_file(filepath):
     """Performs validation on the given metadata file."""
-    return util.validate_file(filepath)
+    from ckanext.spatial.util import validate_file
+    return validate_file(filepath)

ckanext/spatial/plugin.py

@@ -16,7 +16,6 @@
 from ckan.lib.search import SearchError
 from ckan.lib.helpers import json
 
-import ckanext.spatial.views as blueprints
 from ckanext.spatial.cli import get_commands
 from ckanext.spatial.lib import normalize_bbox
 from ckanext.spatial.search import search_backends
@@ -208,20 +207,3 @@ def before_dataset_search(self, search_params):
 
     def get_commands(self):
         return get_commands()
-
-
-class HarvestMetadataApi(p.SingletonPlugin):
-    '''
-    Harvest Metadata API
-    (previously called "InspireApi")
-
-    A way for a user to view the harvested metadata XML, either as a raw file or
-    styled to view in a web browser.
-    '''
-
-    p.implements(p.IBlueprint)
-
-    # IBlueprint
-
-    def get_blueprint(self):
-        return [blueprints.harvest_metadata]

ckanext/spatial/plugin_harvest_metadata_api.py

@@ -0,0 +1,19 @@
+from ckan import plugins as p
+import ckanext.spatial.views as blueprints
+
+
+class HarvestMetadataApi(p.SingletonPlugin):
+    """
+    Harvest Metadata API
+    (previously called "InspireApi")
+
+    A way for a user to view the harvested metadata XML, either as a raw file or
+    styled to view in a web browser.
+    """
+
+    p.implements(p.IBlueprint)
+
+    # IBlueprint
+
+    def get_blueprint(self):
+        return [blueprints.harvest_metadata]

pyproject.toml

@@ -28,7 +28,8 @@ dynamic = ["version"]
 [project.entry-points."ckan.plugins"]
 spatial_metadata = "ckanext.spatial.plugin:SpatialMetadata"
 spatial_query = "ckanext.spatial.plugin:SpatialQuery"
-spatial_harvest_metadata_api = "ckanext.spatial.plugin:HarvestMetadataApi"
+
+spatial_harvest_metadata_api = "ckanext.spatial.plugin_harvest_metadata_api:HarvestMetadataApi"
 
 csw_harvester = "ckanext.spatial.harvesters:CSWHarvester"
 waf_harvester = "ckanext.spatial.harvesters:WAFHarvester"