Fix: Make default_excel_sheet config variable work properly

khanmustaaq · web-flow · commit b2f46e38e866 · 2025-10-19T19:53:07.000-04:00
Fixes Issue #209 The config key was reading from "DEFAULT_EXCEL_SHEET" instead of "ckanext.datapusher_plus.default_excel_sheet", making the configuration variable ineffective. Changed to use the proper namespaced config key so users can configure which Excel sheet to read.
diff --git a/ckanext/datapusher_plus/config.py b/ckanext/datapusher_plus/config.py
@@ -62,7 +62,7 @@
     tk.config.get("ckanext.datapusher_plus.max_content_length", "5000000")
 )
 CHUNK_SIZE = tk.asint(tk.config.get("ckanext.datapusher_plus.chunk_size", "1048576"))
-DEFAULT_EXCEL_SHEET = tk.asint(tk.config.get("DEFAULT_EXCEL_SHEET", 0))
+DEFAULT_EXCEL_SHEET = tk.asint(tk.config.get("ckanext.datapusher_plus.default_excel_sheet", 0))
 SORT_AND_DUPE_CHECK = tk.asbool(
     tk.config.get("ckanext.datapusher_plus.sort_and_dupe_check", True)
 )

Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,7 @@`
`62`	`62`	`tk.config.get("ckanext.datapusher_plus.max_content_length", "5000000")`
`63`	`63`	`)`
`64`	`64`	`CHUNK_SIZE = tk.asint(tk.config.get("ckanext.datapusher_plus.chunk_size", "1048576"))`
`65`		`-DEFAULT_EXCEL_SHEET = tk.asint(tk.config.get("DEFAULT_EXCEL_SHEET", 0))`
	`65`	`+DEFAULT_EXCEL_SHEET = tk.asint(tk.config.get("ckanext.datapusher_plus.default_excel_sheet", 0))`
`66`	`66`	`SORT_AND_DUPE_CHECK = tk.asbool(`
`67`	`67`	`tk.config.get("ckanext.datapusher_plus.sort_and_dupe_check", True)`
`68`	`68`	`)`