Skip to content

Commit ac45581

Browse files
jqnatividadclaude
andcommitted
address review: fix trailing commas in workflows and docs precision
- Use conditional expressions in qsvmcp/qsvlite build steps to avoid trailing commas when addl-qsvlite-features is empty - Move MALLOC_CONF from "always included" to jemalloc-specific in env vars docs to match the actual code behavior - Narrow jemalloc unsupported target note to just Windows (not arm) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 52bba0e commit ac45581

File tree

6 files changed

+6
-6
lines changed

6 files changed

+6
-6
lines changed

.github/workflows/publish-nightly.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ jobs:
101101
command: build
102102
use-cross: false
103103
toolchain: ${{ matrix.rust }}
104-
args: --profile release-nightly --bin qsvmcp -Z build-std=std --features=qsvmcp,nightly,${{ matrix.job.addl-qsvlite-features }} --target ${{ matrix.job.target }} ${{ matrix.job.default-features }}
104+
args: --profile release-nightly --bin qsvmcp -Z build-std=std ${{ matrix.job.addl-qsvlite-features != '' && format('--features=qsvmcp,nightly,{0}', matrix.job.addl-qsvlite-features) || '--features=qsvmcp,nightly' }} --target ${{ matrix.job.target }} ${{ matrix.job.default-features }}
105105
# TODO: Add qsvdp-nightly build back in after v5.0.3, be sure to copy qsvdp binaries below
106106
# - name: Build qsvdp-nightly
107107
# env:

.github/workflows/publish-portable.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ jobs:
193193
command: build
194194
use-cross: ${{ matrix.job.use-cross }}
195195
toolchain: ${{ matrix.rust }}
196-
args: --release --locked --bin qsvmcp --features=qsvmcp,${{ matrix.job.addl-qsvlite-features }} --target ${{ matrix.job.target }} ${{ matrix.job.default-features }}
196+
args: --release --locked --bin qsvmcp ${{ matrix.job.addl-qsvlite-features != '' && format('--features=qsvmcp,{0}', matrix.job.addl-qsvlite-features) || '--features=qsvmcp' }} --target ${{ matrix.job.target }} ${{ matrix.job.default-features }}
197197
- name: Copy binaries to working dir
198198
shell: bash
199199
run: |

.github/workflows/publish.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,7 @@ jobs:
208208
command: build
209209
use-cross: ${{ matrix.job.use-cross }}
210210
toolchain: ${{ matrix.rust }}
211-
args: --release --locked --bin qsvmcp --features=qsvmcp,${{ matrix.job.addl-qsvlite-features }} --target ${{ matrix.job.target }} ${{ matrix.job.default-features }}
211+
args: --release --locked --bin qsvmcp ${{ matrix.job.addl-qsvlite-features != '' && format('--features=qsvmcp,{0}', matrix.job.addl-qsvlite-features) || '--features=qsvmcp' }} --target ${{ matrix.job.target }} ${{ matrix.job.default-features }}
212212
- name: Copy binaries to working dir
213213
shell: bash
214214
run: |

.github/workflows/test-publish-nightly.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ jobs:
8989
command: build
9090
use-cross: false
9191
toolchain: ${{ matrix.rust }}
92-
args: --profile release-nightly --bin qsvlite -Z build-std=std,panic_abort -Z build-std-features=panic_immediate_abort --features=lite,self_update,${{ matrix.job.addl-qsvlite-features }} --target ${{ matrix.job.target }} ${{ matrix.job.default-features }}
92+
args: --profile release-nightly --bin qsvlite -Z build-std=std,panic_abort -Z build-std-features=panic_immediate_abort ${{ matrix.job.addl-qsvlite-features != '' && format('--features=lite,self_update,{0}', matrix.job.addl-qsvlite-features) || '--features=lite,self_update' }} --target ${{ matrix.job.target }} ${{ matrix.job.default-features }}
9393
- name: Build qsvdp-nightly
9494
env:
9595
RUSTFLAGS: --emit=asm

docs/ENVIRONMENT_VARIABLES.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ Several dependencies also have environment variables that influence qsv's perfor
7878
* `POLARS_BACKTRACE_IN_ERR` - if set to 1, includes backtrace in polars-related error messages.
7979

8080
> ℹ️ **NOTE:** To get a list of all active qsv-relevant environment variables, run `qsv --envlist`.
81-
Relevant env vars always include anything that starts with `QSV_`, `MALLOC_CONF` & the proxy variables listed above. Allocator-specific env vars are build-dependent: `MIMALLOC_` vars are included when qsv is built with mimalloc support, and `JEMALLOC_` vars are included when qsv is built with jemalloc support.
81+
Relevant env vars always include anything that starts with `QSV_` & the proxy variables listed above. Allocator-specific env vars are build-dependent: `MIMALLOC_` vars are included when qsv is built with mimalloc support, and `JEMALLOC_` & `MALLOC_CONF` vars are included when qsv is built with jemalloc support.
8282

8383
## MCP Server Environment Variables
8484

docs/PERFORMANCE.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ or
129129
cargo build --release --no-default-features --features all_features
130130
```
131131

132-
To find out what memory allocator qsv is using, run `qsv --version`. After the qsv version number, the allocator used is displayed ("`standard`", "`mimalloc`" or "`jemalloc`"). Note that jemalloc is not supported on Windows and `arm` targets, and you'll need to use the "mimalloc" or "standard" allocator on those platforms.
132+
To find out what memory allocator qsv is using, run `qsv --version`. After the qsv version number, the allocator used is displayed ("`standard`", "`mimalloc`" or "`jemalloc`"). Note that jemalloc is not supported on Windows targets, and you'll need to use the "mimalloc" or "standard" allocator on those platforms.
133133

134134
### Out-of-Memory (OOM) Prevention
135135
Most qsv commands use a "streaming" approach to processing CSVs - "streaming" in the input record-by-record while processing it. This allows it to process arbitrarily large CSVs with constant memory.

0 commit comments

Comments
 (0)