Commit ee00e11
committed
Address review findings (job 438)
Syntax check passed. All changes are complete.
Changes:
- Replace macOS `read -t` fallback with `head -c 65536 | jq` pipeline to fix silent failure when `timeout` is unavailable (finding 1)
- Move version-change note from header preamble to Tool Discovery section where it's more contextually relevant (finding 4)
Address review findings (job 436)
Script passes syntax check. This is a shell script, not a Rust source file, so the standard `cargo build`/`cargo test` commands aren't relevant here. The change is minimal and self-contained.
Changes:
- Added `-n 65536` to `read` builtin in the macOS fallback branch to enforce the same 64KB size limit as the `timeout` branch, addressing the size guard inconsistency
Address review findings (job 435)
Syntax check passed. This is a shell script only — no Rust build or tests needed for these changes.
Changes:
- Use bash `read -t 5` fallback instead of bare `head` on systems without `timeout` (macOS) to prevent indefinite stdin blocking
- Emit diagnostic `additionalContext` message when `CLAUDE_PLUGIN_ROOT` is unset, aiding troubleshooting
- Replace instruction-to-AI phrasing ("Inform the user...") with neutral factual messages in JSON output
Address review findings (job 433)
Script syntax is valid. All three review findings are addressed.
Changes:
- Add `command -v timeout` check with fallback to plain `head` for macOS compatibility (issues #1/#3)
- Guard against empty/unset `CLAUDE_PLUGIN_ROOT` before `cd` to prevent unexpected `$HOME` resolution (issue #2)
Address review findings (job 432)
Script syntax is valid (no output = no errors).
Changes:
- Add 5-second timeout to stdin read to prevent indefinite blocking if no input is provided
- Guard against deploying CLAUDE.md into the plugin's own directory tree
- Replace hardcoded version "v16.1" with version-agnostic wording in cowork template
- Add `stats` (with extended stats) to the memory-intensive commands list in cowork template
Address review findings (job 430)
Script syntax is valid.
Changes:
- Guard `jq` parse of stdin against truncated JSON: redirect stderr and fall back to empty `CWD` on failure, so `set -e` won't abort on malformed input
- Replace `realpath` with POSIX-portable `cd "$CWD" && pwd -P` for symlink resolution, ensuring compatibility on minimal macOS and CI images without GNU coreutils
Address review findings (job 429)
All changes look correct. Since this is a shell script and markdown file (no Rust code changes), there's no build or test to run.
Changes:
- Limit stdin read to 64KB (`head -c 65536`) to prevent hangs on malformed/endless input
- Resolve CWD with `realpath` to prevent path traversal via symlinks
- Add `QSV_NO_COWORK_SETUP=1` env var opt-out mechanism
- Wrap `cp` in error handling to produce a friendly JSON message instead of failing with `set -e`
- Add version note and opt-out instructions to the cowork-CLAUDE.md template header
Address review findings (job 427)
Script syntax is valid (no output means no errors).
Changes:
- Redirect `jq`-missing diagnostic from stderr to stdout so the hook framework can surface it as `additionalContext` to the agent
Address review findings (job 426)
Both files validate correctly. The diagnostic errors about `qsv_bin` are pre-existing and unrelated to these changes.
Changes:
- Use here-string (`<<<`) instead of `echo | jq` to avoid escape sequence mangling in JSON input
- Add `jq` availability check with friendly message instead of cryptic hook error
- Remove misleading `"matcher": "startup"` from SessionStart hook config
- Use `jq -n` to construct output JSON safely, preventing malformed JSON from paths with special characters
- Remove unverified `QSV_MCP_OPERATION_TIMEOUT_MS` / `qsv_config` references from cowork-CLAUDE.md template1 parent 8d9df1c commit ee00e11
File tree
3 files changed
+39
-15
lines changed- .claude/skills
- .claude-plugin
- scripts
3 files changed
+39
-15
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
28 | | - | |
29 | 28 | | |
30 | 29 | | |
31 | 30 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| 5 | + | |
5 | 6 | | |
6 | 7 | | |
7 | 8 | | |
| |||
34 | 35 | | |
35 | 36 | | |
36 | 37 | | |
37 | | - | |
| 38 | + | |
38 | 39 | | |
39 | 40 | | |
40 | 41 | | |
41 | 42 | | |
42 | 43 | | |
43 | 44 | | |
44 | 45 | | |
45 | | - | |
| 46 | + | |
46 | 47 | | |
47 | 48 | | |
48 | 49 | | |
49 | | - | |
| 50 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
9 | | - | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
10 | 18 | | |
11 | | - | |
12 | | - | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
13 | 22 | | |
14 | 23 | | |
15 | 24 | | |
16 | 25 | | |
17 | 26 | | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
18 | 40 | | |
19 | 41 | | |
20 | 42 | | |
| |||
25 | 47 | | |
26 | 48 | | |
27 | 49 | | |
28 | | - | |
29 | | - | |
30 | | - | |
| 50 | + | |
| 51 | + | |
31 | 52 | | |
32 | 53 | | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
37 | 61 | | |
0 commit comments