prevent setState after unmount

Tim Smart · Tim Smart · commit 5c89327d0e58 · 2023-09-09T08:54:18.000+12:00
diff --git a/src/hooks/useResultCallback.ts b/src/hooks/useResultCallback.ts
@@ -36,6 +36,7 @@ export const makeUseResultCallback: <R>(
     useEffect(() =>
       () => {
         if (fiberState.current._tag === "Running") {
+          Effect.runSync(Ref.set(fiberState.current.interruptingRef, true))
           Effect.runFork(Fiber.interruptFork(fiberState.current.fiber))
         }
       }, [])
@@ -45,7 +46,6 @@ export const makeUseResultCallback: <R>(
       if (fiberState.current._tag === "Running") {
         Effect.runSync(Ref.set(fiberState.current.interruptingRef, true))
         Effect.runFork(Fiber.interruptFork(fiberState.current.fiber))
-        fiberState.current = { _tag: "Idle" }
       }
 
       trackRef.current.invocationCount++

Original file line number	Diff line number	Diff line change
`@@ -36,6 +36,7 @@ export const makeUseResultCallback: <R>(`
`36`	`36`	`useEffect(() =>`
`37`	`37`	`() => {`
`38`	`38`	`if (fiberState.current._tag === "Running") {`
	`39`	`+ Effect.runSync(Ref.set(fiberState.current.interruptingRef, true))`
`39`	`40`	`Effect.runFork(Fiber.interruptFork(fiberState.current.fiber))`
`40`	`41`	`}`
`41`	`42`	`}, [])`
`@@ -45,7 +46,6 @@ export const makeUseResultCallback: <R>(`
`45`	`46`	`if (fiberState.current._tag === "Running") {`
`46`	`47`	`Effect.runSync(Ref.set(fiberState.current.interruptingRef, true))`
`47`	`48`	`Effect.runFork(Fiber.interruptFork(fiberState.current.fiber))`
`48`		`- fiberState.current = { _tag: "Idle" }`
`49`	`49`	`}`
`50`	`50`
`51`	`51`	`trackRef.current.invocationCount++`