Skip to content

Commit fc5065a

Browse files
committed
docs: fix grammar
1 parent 98e9731 commit fc5065a

File tree

9 files changed

+28
-28
lines changed

9 files changed

+28
-28
lines changed

docs/index.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ dbterd run -ad samples/local -rt model -rt source
104104

105105
### Python API Examples
106106

107-
- Generate Complete ERD:
107+
- Generate a Complete ERD:
108108

109109
```python
110110
from dbterd.api import DbtErd
@@ -118,7 +118,7 @@ erd = DbtErd(target="mermaid").get_erd()
118118
print("ERD (Mermaid):", erd)
119119
```
120120

121-
- Generate Single Model ERD:
121+
- Generate a Single Model ERD:
122122

123123
```python
124124
from dbterd.api import DbtErd

docs/nav/guide/choose-algo.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,14 +58,14 @@ Ref: "order_items"."order_id" > "orders"."order_id"
5858
5959
Awesome, job done here 🎉
6060
61-
NO, not yet (maybe!), sometime this module is not going to work perfectly due to:
61+
NO, not yet (maybe!), sometimes this module is not going to work perfectly due to:
6262
6363
- Some relationship tests are added from `mart` to `staging` just for ensuring no missing data when moving from a layer to another.
6464
- That's why we have the [ignore_in_erd](https://dbterd.datnguyen.de/1.15/nav/metadata/ignore_in_erd.html) metadata config.
6565
- We have the tests done in separate tools already (e.g. Soda), there is no reason to duplicate the (relationship) tests here.
6666
- No problem! Let's still add it with `where: 1=0` or with the dummy relationship tests (see this [blogpost](https://medium.com/@vaibhavchopda04/generating-erds-from-dbt-projects-a-code-driven-approach-83abb957f483))
6767
68-
In case that we don't want to leverage the dbt tests still, let's move on the next section for the alternative 🏃
68+
In case we don't want to leverage the dbt tests still, let's move on to the next section for the alternative 🏃
6969
7070
## Semantic Entities
7171

docs/nav/guide/cli-references.md

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ Command to generate diagram-as-a-code file from dbt artifact files, optionally d
7171
from Administrative API (dbt Cloud) before hands.
7272

7373
Options:
74-
-s, --select TEXT Selecttion criteria
74+
-s, --select TEXT Selection criteria
7575
-ns, --exclude TEXT Exclusion criteria
7676
-t, --target TEXT Target to the diagram-as-code platform
7777
[default: dbml]
@@ -140,7 +140,7 @@ Command to generate diagram-as-a-code file from dbt artifact files, optionally d
140140
### dbterd run --select (-s)
141141

142142
Selection criteria.
143-
> Select all dbt models if not specified, supports multiple options
143+
> Selects all dbt models if not specified, supports multiple options
144144
145145
Rules:
146146

@@ -211,7 +211,7 @@ Rules:
211211
### dbterd run --exclude (-ns)
212212

213213
Exclusion criteria. Rules are the same as Selection Criteria.
214-
> Do not exclude any dbt models if not specified, supports multiple options
214+
> Does not exclude any dbt models if not specified, supports multiple options
215215
216216
**Examples:**
217217
=== "CLI"
@@ -229,7 +229,7 @@ Exclusion criteria. Rules are the same as Selection Criteria.
229229

230230
Configure the path to directory containing dbt artifact files.
231231

232-
It will take the the nested `/target` directory of `--dbt-project-dir` if not specified.
232+
It will take the nested `/target` directory of `--dbt-project-dir` if not specified.
233233

234234
> Default to the current directory's `/target` if both this option and `--dbt-project-dir` option are not specified
235235
@@ -321,7 +321,7 @@ Supported target, please visit [Generate the Targets](https://dbterd.datnguyen.d
321321

322322
### dbterd run --algo (-a)
323323

324-
Specified algorithm in the way to detect diagram connectors
324+
Specified algorithm for detecting diagram connectors
325325

326326
Check the [docs](./choose-algo.md) 📖
327327

@@ -471,7 +471,7 @@ Flag to indicate the Selection to follow dbt's one leveraging Programmatic Invoc
471471

472472
Flag to indicate force running `dbt docs generate` to the targeted project in order to produce the dbt artifact files.
473473

474-
This option have to be enabled together with `--dbt` option, and will override the value of `--artifacts-dir` to be using the `/target` dir of the value of `--dbt-project-dir`.
474+
This option has to be enabled together with `--dbt` option, and will override the value of `--artifacts-dir` to use the `/target` dir of the value of `--dbt-project-dir`.
475475

476476
> Default to `False`
477477
@@ -486,7 +486,7 @@ This option have to be enabled together with `--dbt` option, and will override t
486486

487487
Specified dbt project directory path
488488

489-
You should specified this option if your CWD is not the dbt project dir, and normally used with `--dbt` enabled. It will take the value of `--artifacts-dir` if not specified.
489+
You should specify this option if your CWD is not the dbt project dir, and normally used with `--dbt` enabled. It will take the value of `--artifacts-dir` if not specified.
490490

491491
> Default to the current directory if both this option and `--artifacts-dir` option are not specified
492492
@@ -623,7 +623,7 @@ Check [this guideline](./dbt-cloud/read-artifact-from-an-environment.md) for mor
623623
Generate ERD file from reading Discovery API (dbt Cloud).
624624

625625
Options:
626-
-s, --select TEXT Selecttion criteria
626+
-s, --select TEXT Selection criteria
627627
-ns, --exclude TEXT Exclusion criteria
628628
-t, --target TEXT Target to the diagram-as-code platform
629629
[default: dbml]
@@ -738,7 +738,7 @@ Shows hidden configured values, which will help us to see what configs are passe
738738
Inspect the hidden magics.
739739

740740
Options:
741-
-s, --select TEXT Selecttion criteria
741+
-s, --select TEXT Selection criteria
742742
-ns, --exclude TEXT Exclusion criteria
743743
-t, --target TEXT Target to the diagram-as-code platform
744744
[default: dbml]

docs/nav/guide/dbt-cloud/download-artifact-from-a-job-run.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ Behind the scene, the API Endpoint will look like:
2121
https://{host_url}/api/{api_version}/accounts/{account_id}/runs/{run_id}/artifacts/{path}
2222
```
2323

24-
And the dbt Cloud's Job Rub will have the URL constructed as:
24+
And the dbt Cloud's Job Run will have the URL constructed as:
2525

2626
```log
2727
https://<host_url>/deploy/<account_id>/projects/irrelevant/runs/<run_id>
@@ -69,7 +69,7 @@ $env:DBTERD_DBT_CLOUD_API_VERSION="your_value" # optional, default = v2
6969

7070
We're going to use `--dbt-cloud` option to tell `dbterd` to use dbt Cloud API with all above variables.
7171

72-
The command will be looks like:
72+
The command will look like:
7373

7474
```bash
7575
dbterd run --dbt-cloud [-s <dbterd selection>]

docs/nav/guide/dbt-cloud/read-artifact-from-an-environment.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
# Read the latest artifacts from an environment
22

3-
This is a guideline on how to query the dbt cloud metadata given an environment by using [dbt CLoud Discovery API](https://docs.getdbt.com/docs/dbt-cloud-apis/discovery-api). It's neither not requiring `JOB ID` nor `JOB RUN ID`, this is the dbt Cloud's `ENVIRONMENT ID`. Especially, with this method, `dbterd` doesn't require to download files before hands anymore, the ERD will be generated on fly 🚀.
3+
This is a guideline on how to query the dbt cloud metadata given an environment by using [dbt Cloud Discovery API](https://docs.getdbt.com/docs/dbt-cloud-apis/discovery-api). It doesn't require `JOB ID` or `JOB RUN ID`, but rather the dbt Cloud's `ENVIRONMENT ID`. Especially, with this method, `dbterd` doesn't require downloading files beforehand anymore, the ERD will be generated on the fly 🚀.
44

5-
`dbterd` is now understanding GraphQL connection which is exposed by dbt CLoud Discovery API endpoint:
5+
`dbterd` now understands GraphQL connections which are exposed by dbt Cloud Discovery API endpoint:
66

77
```log
88
https://metadata.YOUR_ACCESS_URL/graphql
@@ -15,7 +15,7 @@ https://metadata.YOUR_ACCESS_URL/graphql
1515
- You must be on a [Team or Enterprise plan](https://www.getdbt.com/pricing/) 💰
1616
- Your projects must be on dbt version 1.0 or later 🏃
1717

18-
The assumption is that you've already get the dbt Cloud project ready and is having at least 1 environment, and 1 job run successfully in this environment.
18+
The assumption is that you've already got the dbt Cloud project ready and have at least 1 environment, and 1 job run successfully in this environment.
1919

2020
## 1. Prepare the environment variables
2121

@@ -68,13 +68,13 @@ $env:DBTERD_DBT_CLOUD_ENVIRONMENT_ID="your_value"
6868

6969
We're going to use a new command as `dbterd run-metadata` to tell `dbterd` to use dbt Cloud Discovery API with all above variables.
7070

71-
The command will be looks like:
71+
The command will look like:
7272

7373
```bash
7474
dbterd run-metadata [-s <dbterd selection>]
7575
```
7676

77-
> Behind the scenes, it will try use to the ERD GraphQL query built-in at [include/erd_query.gql](https://github.com/datnguye/dbterd/tree/main/dbterd/adapters/dbt_cloud/include/erd_query.gql)
77+
> Behind the scenes, it will try to use the ERD GraphQL query built-in at [include/erd_query.gql](https://github.com/datnguye/dbterd/tree/main/dbterd/adapters/dbt_cloud/include/erd_query.gql)
7878
7979
and then, here is the sample console log:
8080

docs/nav/guide/targets/generate-drawdb.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,12 +58,12 @@ There we go, here is the sample output content:
5858

5959
## 3. Import to Draw DB Editor
6060

61-
Go to the [Draw DB Editor](https://drawdb.vercel.app/editor) playaround:
61+
Go to the [Draw DB Editor](https://drawdb.vercel.app/editor) to play around:
6262

6363
- Files > Import diagram
6464
- Choose the generated file e.g. `erd.ddb`
6565
- Click `Import`
6666

67-
Voila 🎉, here the result:
67+
Voila 🎉, here's the result:
6868

6969
![import-ddb.png](./../../../assets/images/import-ddb.png)

docs/nav/guide/targets/generate-markdown-mermaid-erd.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
<span data-ty data-ty-prompt="$ ~/repo>"></span>
2424
</div>
2525

26-
### 3. Commit it and check it on Github
26+
### 3. Commit it and check it on GitHub
2727

2828
Check out the [sample](https://github.com/datnguye/dbterd/blob/main/samples/dbtresto/ERD.md) output:
2929

docs/nav/guide/targets/generate-plantuml.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,15 +14,15 @@
1414
- Paste the PlantUML content generated as above
1515
- Wait for a second and get the URL
1616

17-
### 3. Embedded the PlantUML URL into Markdown
17+
### 3. Embed the PlantUML URL into Markdown
1818

1919
```markdown
2020
![](https://www.plantuml.com/plantuml/dpng/{your-hash})
2121
```
2222

2323
![erd](https://www.plantuml.com/plantuml/dpng/fLRRZgCm37tlLw3vW4hbGgLzcZ-9N71tK251IPZPxhR_lh08gnjCZ3HzAPpZayknu_3kF5W_TEq1jM_yFNdhJ8tjiRvuPT5vSwoRJbtChxVapo4PV-EZkk4z-P5yWgq-m1BQr0nOWySHdlu8i-Y6rYizT1UqRcGrgRW8THf36kqts3JAPb4sZx95b2sZx9dOPzJPoPZ5skbvyfRyuZmax1xC_uLu2w3EQF_1OKf3XqosxWXsvy9xs_ocbVzx2Sg2y6KolMQChN7FX5Ue5cUNAUStzGdjW2zRD5KrM8kwua7L6wTEsrIwJMNRLBvD5TjKkKsTNwWMd5VGzmWMT4M545AqEIaWbG8oAI2N0Wefe9G2pXImhohKrLYimFcbF9Rt-V24it6dYXJKbwYKIITtBnhb5AOmtjT8bygwbDDbiYxZTBciopbT8UiAJbUAEWhPctjN6TledvJwaM9w4LSHiKuoZOhgj4BI5PAja7o552larGWB-aQdzzeQ2E2KXpCUpdcuuE6IOD7lEKtaCn34Vn4mA7zHy5UVDifSrPVHPDIYdrD5ooQyXwR-3swScXaFDzHxoyfXUDc8vpwyTuJM_JmamYNtV1oFZqVac-6G24cAZJ3kvri3pAxAGyYxU4TT3rtx5m00)
2424

25-
## Known Limitation💡
25+
## Known Limitations💡
2626

27-
- Plant UML connectors seem not to support to indicate the columns which are related to the Relationship
28-
- Left the question _"How to automate the markdown image URL generated?"_ opened
27+
- PlantUML connectors don't seem to support indicating the columns which are related to the Relationship
28+
- The question _"How to automate the markdown image URL generation?"_ remains open

docs/nav/metadata/relationship_type.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,4 +30,4 @@ List of accepted values:
3030
| many-to-one | n1 |
3131
| Not specified/Invalid value | n1 |
3232

33-
> NOTE: Known as we could configure multiple relationship types but in the best practice we should always have `many-to-one`
33+
> NOTE: We know that we could configure multiple relationship types but in best practice we should always have `many-to-one`

0 commit comments

Comments
 (0)