[sentry][s]: refactored commands to send error reports to Sentry - refs #321

- removed exiting with code 1 as it now happens after Sentry report is sent and happens in one place
- when catching errors, 'handleError' function should be called lastly as `process.exit(1)` happens in the callback and we don't want it to exit before other scripts are executed

Author: anuveyatsu

bin/data-cat.js

@@ -55,7 +55,6 @@ const dumpIt = async (res, {sheet}={}) => {
         error('Provided URL is invalid')
       }
       handleError(err)
-      process.exit(1)
     }
 
     if (outFormat === 'ascii') { // Write to stdout

bin/data-get.js

@@ -105,11 +105,10 @@ const run = async () => {
 
   } catch (err) {
     stopSpinner()
-    handleError(err)
     if (argv.debug) {
       console.log('> [debug]\n' + err.stack)
     }
-    process.exit(1)
+    handleError(err)
   }
 }
 
@@ -135,7 +134,6 @@ const saveFileFromUrl = (url, format) => {
         err.message += ' or Forbidden.'
       }
       handleError(err)
-      process.exit(1)
     }
     stream.pipe(fs.createWriteStream(destPath)).on('finish', () => {
       resolve(destPath)

bin/data-info.js

@@ -66,10 +66,9 @@ Promise.resolve().then(async () => {
       }
     }
   } catch (err) {
-    handleError(err)
     if (!argv._[0]) {
       printInfo('Running `data info` without an argument will search a `datapackage.json` file in the current working directory.')
     }
-    process.exit(1)
+    handleError(err)
   }
 })

bin/data-login.js

@@ -38,7 +38,6 @@ Promise.resolve().then(async () => {
     out = await authenticate(apiUrl, token)
   } catch (err) {
     handleError(err)
-    process.exit(1)
   }
   if (out.authenticated) {
     stopSpinner()

bin/data-push-flow.js

@@ -42,7 +42,6 @@ Promise.resolve().then(async () => {
     out = await authenticate(apiUrl, token)
   } catch (err) {
     handleError(err)
-    process.exit(1)
   }
   if (!out.authenticated) {
     info('You need to login in order to push your data. Please, use `data login` command.')
@@ -73,10 +72,9 @@ Promise.resolve().then(async () => {
     console.log(message + '🔗  ' + url + ' (copied to clipboard)')
   } catch (err) {
     stopSpinner()
-    handleError(err)
     if (argv.debug) {
       console.log('> [debug]\n' + err.stack)
     }
-    process.exit(1)
+    handleError(err)
   }
 })

bin/data-push.js

@@ -48,7 +48,6 @@ Promise.resolve().then(async () => {
       out = await authenticate(apiUrl, token)
     } catch (err) {
       handleError(err)
-      process.exit(1)
     }
   }
   if (!out.authenticated) {
@@ -66,12 +65,11 @@ Promise.resolve().then(async () => {
       try {
         dataset = await Dataset.load(filePath)
       } catch(err){
-        error(err.message)
         info("You can run:")
         info("'data validate' to check your data.")
         info("'data init' to create a datapackage.")
         info("'data help push' to get more info.")
-        process.exit(1)
+        handleError(err)
       }
     } else {
       dataset = await prepareDatasetFromFile(filePath)
@@ -136,11 +134,10 @@ Promise.resolve().then(async () => {
     console.log(message + '🔗  ' + url + copied)
   } catch (err) {
     stopSpinner()
-    handleError(err)
     if (argv.debug) {
       console.log('> [debug]\n' + err.stack)
     }
-    process.exit(1)
+    handleError(err)
   }
 })