[analytics][xs]: differentiate no arguments vs help command when tracking with GA - fixes #331

anuveyatsu · anuveyatsu · commit f29a0bf2109b · 2018-04-11T22:04:48.000+06:00
diff --git a/bin/data.js b/bin/data.js
@@ -116,7 +116,8 @@ if (process.env.datahub !== 'dev') {
   // Track which version is run and on which OS:
   visitor.event('cli-usage-by-os-and-version', process.platform, version).send()
   // Event category is 'cli', action is the command and label is all arguments:
-  visitor.event('cli', cmd, process.argv.slice(3, process.argv.length).toString()).send()
+  const commandToTrack = args.length === 0 ? 'noArgs' : cmd
+  visitor.event('cli', commandToTrack, process.argv.slice(3, process.argv.length).toString()).send()
 }
 
 // Prepare process.argv for subcommand

Original file line number	Diff line number	Diff line change
`@@ -116,7 +116,8 @@ if (process.env.datahub !== 'dev') {`
`116`	`116`	`// Track which version is run and on which OS:`
`117`	`117`	`visitor.event('cli-usage-by-os-and-version', process.platform, version).send()`
`118`	`118`	`// Event category is 'cli', action is the command and label is all arguments:`
`119`		`- visitor.event('cli', cmd, process.argv.slice(3, process.argv.length).toString()).send()`
	`119`	`+ const commandToTrack = args.length === 0 ? 'noArgs' : cmd`
	`120`	`+ visitor.event('cli', commandToTrack, process.argv.slice(3, process.argv.length).toString()).send()`
`120`	`121`	`}`
`121`	`122`
`122`	`123`	`// Prepare process.argv for subcommand`