Skip to content

Commit ff89a4b

Browse files
committed
remove & add TODO
1 parent 3b521e5 commit ff89a4b

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

src/common/node.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@ pub struct Node {
2323
/// This node's index in the Merkle tree
2424
pub(crate) index: u64,
2525
/// Hash of the data in this node
26+
// TODO make this [u8; 32] like:
27+
// https://github.com/holepunchto/hypercore/blob/d21ebdeca1b27eb4c2232f8af17d5ae939ee97f2/lib/messages.js#L246
2628
pub(crate) hash: Vec<u8>,
2729
/// Number of bytes in this [`Node::data`]
2830
pub(crate) length: u64,

src/oplog/mod.rs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -304,9 +304,6 @@ impl Oplog {
304304

305305
let mut size = len * LEADER_SIZE;
306306

307-
// TODO: should I add back the fn sum_encoded_size(&[impl CompactEncoding])-> usize?
308-
// it could be used here. I thought there would not be a case where we were encoding a
309-
// runtime defined number of types in a row and it not be as a Vec (length prefixed) thing
310307
for e in batch.iter() {
311308
size += e.encoded_size()?;
312309
}

0 commit comments

Comments
 (0)