Fix bug in updating ready condition when it's already present in the instance.

Author: joshlreese

internal/controller/instance_controller.go

@@ -82,6 +82,8 @@ func (r *InstanceReconciler) reconcileInstanceReadyCondition(
 			ObservedGeneration: instance.Generation,
 			Message:            "Instance has not been programmed",
 		}
+	} else {
+		readyCondition = readyCondition.DeepCopy()
 	}
 
 	if instance.Spec.Controller != nil && len(instance.Spec.Controller.SchedulingGates) > 0 {

internal/controller/instance_controller_test.go

@@ -55,6 +55,18 @@ func TestReconcileInstanceReadyCondition(t *testing.T) {
 						},
 					},
 				},
+				Status: computev1alpha.InstanceStatus{
+					Conditions: []metav1.Condition{
+						{
+							Type:               computev1alpha.InstanceReady,
+							Status:             metav1.ConditionFalse,
+							Reason:             computev1alpha.InstanceProgrammedReasonPendingProgramming,
+							Message:            "Instance has not been programmed",
+							ObservedGeneration: 1,
+							LastTransitionTime: metav1.Now(),
+						},
+					},
+				},
 			},
 			expectedChanged: true,
 			expectedCondition: &metav1.Condition{