Address linter violations.

Author: joshlreese

internal/controller/instance_controller.go

@@ -78,6 +78,7 @@ func (r *InstanceReconciler) Reconcile(ctx context.Context, req mcreconcile.Requ
 		return ctrl.Result{}, nil
 	}
 
+	pendingReason := "Pending"
 	if condition := apimeta.FindStatusCondition(instance.Status.Conditions, computev1alpha.InstanceProgrammed); condition.Status != metav1.ConditionTrue {
 		logger.Info("instance is not programmed", "instance", instance.Name)
 		message := "Instance has not been programmed"
@@ -86,7 +87,7 @@ func (r *InstanceReconciler) Reconcile(ctx context.Context, req mcreconcile.Requ
 		}
 
 		reason := computev1alpha.InstanceProgrammedReasonPendingProgramming
-		if condition.Reason != "Pending" {
+		if condition.Reason != pendingReason {
 			reason = condition.Reason
 		}
 
@@ -114,8 +115,8 @@ func (r *InstanceReconciler) Reconcile(ctx context.Context, req mcreconcile.Requ
 			message = condition.Message
 		}
 
-		reason := "Pending"
-		if condition.Reason != "Pending" {
+		reason := pendingReason
+		if condition.Reason != pendingReason {
 			reason = condition.Reason
 		}
 

internal/controller/result.go

@@ -54,7 +54,7 @@ func (r *Result) AddStatusUpdate(c client.Client, obj client.Object) {
 }
 
 func (r Result) ShouldReturn() bool {
-	return r.Err != nil || !r.Result.IsZero() || r.StopProcessing
+	return r.Err != nil || !r.IsZero() || r.StopProcessing
 }
 
 func (r Result) Complete(ctx context.Context) (ctrl.Result, error) {

internal/controller/workloaddeployment_controller.go

@@ -124,11 +124,6 @@ func (r *WorkloadDeploymentReconciler) Reconcile(ctx context.Context, req mcreco
 
 	result := r.reconcileNetworks(ctx, cl.GetClient(), &deployment)
 	if result.ShouldReturn() {
-		if result.Err == nil {
-			// TODO(jreese) update instance status conditions to communicate what
-			// we're waiting on.
-		}
-
 		return result.Complete(ctx)
 	}
 
@@ -175,7 +170,7 @@ func (r *WorkloadDeploymentReconciler) Reconcile(ctx context.Context, req mcreco
 	patchResult, err := controllerutil.CreateOrPatch(ctx, cl.GetClient(), &deployment, func() error {
 		deployment.Status.Replicas = int32(replicas)
 		deployment.Status.CurrentReplicas = int32(currentReplicas)
-		deployment.Status.DesiredReplicas = int32(desiredReplicas)
+		deployment.Status.DesiredReplicas = desiredReplicas
 
 		if readyReplicas > 0 {
 			apimeta.SetStatusCondition(&deployment.Status.Conditions, metav1.Condition{
@@ -184,7 +179,6 @@ func (r *WorkloadDeploymentReconciler) Reconcile(ctx context.Context, req mcreco
 				Reason:  "StableInstanceFound",
 				Message: fmt.Sprintf("%d/%d instances are ready", readyReplicas, replicas),
 			})
-		} else {
 		}
 
 		return nil
@@ -484,7 +478,7 @@ func enqueueWorkloadDeploymentByLocation(ctx context.Context, mgr mcmanager.Mana
 		return nil
 	}
 
-	var requests []mcreconcile.Request
+	requests := make([]mcreconcile.Request, 0, len(workloadDeployments.Items))
 	for _, workload := range workloadDeployments.Items {
 		requests = append(requests, mcreconcile.Request{
 			Request: reconcile.Request{