Commit e23acc3
Drop hardcoded namespaces, fix install via kubectl apply
Tested end-to-end against a local kind cluster and found several real
issues that this commit cleans up:
- Resources no longer hardcode "namespace: system"; the namespace is set
in one place (the overlay) via kustomize's namespace transform.
Consumers can override via Flux's targetNamespace or by editing the
overlay.
- The webhook serving cert mount moves into base/manager/manager.yaml
with the secret marked optional, so consumers composing base/manager
directly (e.g. a future cross-cluster overlay) get the mount for free
and don't crash if they're running webhook-less.
- A new base/webhook/kustomizeconfig.yaml teaches kustomize about the
webhook clientConfig.service.{name,namespace} field paths, so the
namespace transform handles them automatically rather than needing
per-overlay replacements.
- The Certificate's dnsNames now use SERVICE_NAME / SERVICE_NAMESPACE
placeholders (the kubebuilder pattern) and the overlay substitutes
them via replacements pulling from the webhook Service.
- Drops a stale --metrics-bind-address arg patch that referenced a CLI
flag the binary no longer accepts (metrics config moved into the
WorkloadOperator config struct).
- Drops an orphaned metrics_service.yaml from the overlay that wasn't
referenced from kustomization.yaml.
- The default config.yaml now includes a webhookServer block so the
bundle deploys a working webhook out of the box. Consumers running
hermetic without webhooks can omit it (the binary skips the webhook
server entirely when the field is nil).
Verified end-to-end: manager pod 1/1 Running, Certificate ready,
admission webhook serving and being called by the apiserver.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>1 parent f97093b commit e23acc3
16 files changed
Lines changed: 132 additions & 108 deletions
File tree
- config
- base
- certmanager
- manager
- webhook
- components
- controller_rbac
- leader_election
- network-policy
- prometheus
- overlays/single-cluster
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | | - | |
3 | | - | |
4 | 1 | | |
5 | 2 | | |
6 | 3 | | |
7 | 4 | | |
8 | 5 | | |
9 | 6 | | |
10 | 7 | | |
11 | | - | |
12 | 8 | | |
13 | 9 | | |
14 | 10 | | |
15 | 11 | | |
16 | 12 | | |
17 | 13 | | |
18 | 14 | | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | | - | |
| 15 | + | |
24 | 16 | | |
25 | 17 | | |
26 | | - | |
27 | 18 | | |
| 19 | + | |
| 20 | + | |
28 | 21 | | |
29 | | - | |
30 | | - | |
| 22 | + | |
| 23 | + | |
31 | 24 | | |
32 | 25 | | |
33 | 26 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
33 | 37 | | |
34 | 38 | | |
35 | 39 | | |
| |||
57 | 61 | | |
58 | 62 | | |
59 | 63 | | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
60 | 67 | | |
61 | 68 | | |
62 | 69 | | |
63 | 70 | | |
64 | 71 | | |
65 | 72 | | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
10 | 15 | | |
11 | 16 | | |
12 | 17 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
12 | 11 | | |
13 | 12 | | |
14 | 13 | | |
| |||
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
12 | 11 | | |
13 | 12 | | |
14 | 13 | | |
| |||
0 commit comments