Don't remove directories unless told to.

Author: dave-shawley

setupext/janitor/__init__.py

@@ -46,6 +46,9 @@ def initialize_options(self):
 
     def run(self):
         _CleanCommand.run(self)
+        if not self.dist:
+            return
+
         dist_dirs = set()
         for cmd_name in self.distribution.commands:
             if 'dist' in cmd_name:

tests.py

@@ -81,14 +81,16 @@ def setUpClass(cls):
 
     @classmethod
     def create_directory(cls, dir_name):
-        full_path = os.path.join(cls.temp_dir, dir_name)
-        os.mkdir(full_path)
-        return full_path
+        return tempfile.mkdtemp(dir=cls.temp_dir, prefix=dir_name)
 
     def assert_path_does_not_exist(self, full_path):
         if os.path.exists(full_path):
             raise AssertionError('{0} should not exist'.format(full_path))
 
+    def assert_path_exists(self, full_path):
+        if not os.path.exists(full_path):
+            raise AssertionError('{0} should exist'.format(full_path))
+
     def test_that_dist_directory_is_removed_for_sdist(self):
         dist_dir = self.create_directory('dist-dir')
         run_setup(
@@ -115,3 +117,14 @@ def test_that_multiple_dist_directories_with_be_removed(self):
         )
         self.assert_path_does_not_exist(sdist_dir)
         self.assert_path_does_not_exist(bdist_dir)
+
+    def test_that_directories_are_not_removed_without_parameter(self):
+        sdist_dir = self.create_directory('sdist-dir')
+        bdist_dir = self.create_directory('bdist_dumb')
+        run_setup(
+            'sdist', '--dist-dir={0}'.format(sdist_dir),
+            'bdist_dumb', '--dist-dir={0}'.format(bdist_dir),
+            'clean',
+        )
+        self.assert_path_exists(sdist_dir)
+        self.assert_path_exists(bdist_dir)