Now all #if 0 have a comment explaining why.

	modified:   src/lib/libdwarf/dwarf_elf_load_headers.c
	modified:   src/lib/libdwarf/dwarf_generic_init.c
	modified:   src/lib/libdwarf/dwarf_global.c
	modified:   src/lib/libdwarf/dwarf_init_finish.c
	modified:   src/lib/libdwarf/dwarf_line.h
	modified:   src/lib/libdwarf/dwarf_macro5.c
	modified:   src/lib/libdwarf/dwarf_object_detector.c

Author: davea42

src/lib/libdwarf/dwarf_elf_load_headers.c

@@ -493,15 +493,13 @@ generic_shdr_from_shdr32(dwarf_elf_object_access_internals_t *ep,
 
         gshdr->gh_secnum = i;
         copysection32(ep,gshdr,psh);
-#if 1
         if (gshdr->gh_size >= ep->f_filesize &&
             gshdr->gh_type != SHT_NOBITS) {
             free(orig_psh);
             free(orig_gshdr);
             *errcode = DW_DLE_SECTION_SIZE_ERROR;
             return DW_DLV_ERROR;
         }
-#endif /* 0 */
         isempty = is_empty_section(gshdr->gh_type);
         if (i == 0) {
             Dwarf_Unsigned shnum = 0;

src/lib/libdwarf/dwarf_generic_init.c

@@ -454,10 +454,7 @@ dwarf_init_b(int fd,
     Dwarf_Unsigned   filesize = 0;
     int res = 0;
     int errcode = 0;
-#if 0
-    void *inmem_data;
-    Dwarf_Unsigned inmem_size = 0;
-#endif
+
     if (!ret_dbg) {
         DWARF_DBG_ERROR(NULL,DW_DLE_DWARF_INIT_DBG_NULL,DW_DLV_ERROR);
     }

src/lib/libdwarf/dwarf_global.c

@@ -1069,7 +1069,6 @@ _dwarf_internal_get_pubnames_like(Dwarf_Debug dbg,
             *out_phead_chain = 0;
             return DW_DLV_ERROR;
         }
-#if 1
         /*  If there is some kind of padding at the end of
             the section, following a pairs terminator,
             as emitted by some compilers, skip over that padding and
@@ -1084,7 +1083,6 @@ _dwarf_internal_get_pubnames_like(Dwarf_Debug dbg,
                 pubnames_like_offset = finaloffset;
             }
         }
-#endif
         pubnames_like_ptr = pubnames_ptr_past_end_cu;
     } while (pubnames_like_ptr < section_end_ptr);
     *return_count = global_count;

src/lib/libdwarf/dwarf_init_finish.c

@@ -1196,7 +1196,7 @@ dwarf_object_finish(Dwarf_Debug dbg)
 
 #if defined(HAVE_ZLIB) && defined(HAVE_ZSTD)
 
-#if 0
+#if 0 /* Dropping heuristic check. Not reliable. */
 static int
 check_uncompr_inflation(Dwarf_Debug dbg,
     Dwarf_Error *error,
@@ -1294,7 +1294,7 @@ check_uncompr_inflation(Dwarf_Debug dbg,
 
     */
 
-#if 0
+#if 0 /* Dropping heuristic check. Not reliable. */
 /*  ALLOWED_ZLIB_INFLATION is a heuristic, not necessarily right.
     The test case klingler2/compresseddebug.amd64 actually
     inflates about 8 times.  */
@@ -1389,7 +1389,7 @@ do_decompress(Dwarf_Debug dbg,
             " The compressed section is not properly formatted");
         return DW_DLV_ERROR;
     }
-#if 0
+#if 0 /* Dropping heuristic check. Not reliable. */
     /*  The heuristics are unreliable. Turned off now  */
     if (!zstdcompress) {
         /*  According to zlib.net zlib essentially never expands
@@ -1558,7 +1558,7 @@ _dwarf_load_section(Dwarf_Debug dbg,
     if (res == DW_DLV_ERROR) {
         DWARF_DBG_ERROR(dbg, errc, DW_DLV_ERROR);
     }
-#if 0
+#if 0 /* Not changing error, to disruptive of regression tests. */
 Hold off on this, keep old error for the moment
     if (res == DW_DLV_ERROR) {
         _dwarf_error_string(dbg, error,

src/lib/libdwarf/dwarf_line.h

@@ -302,7 +302,6 @@ void _dwarf_set_line_table_regs_default_values(
 */
 struct Dwarf_Line_s {
     Dwarf_Addr li_address;  /* pc value of machine instr */
-#if 1
     struct li_inner_s {
         /* New as of DWARF4 */
         Dwarf_Unsigned li_discriminator;
@@ -348,7 +347,6 @@ struct Dwarf_Line_s {
         /* Mark a line record as being DW_LNS_set_address. */
         unsigned li_is_addr_set:1;
     } li_l_data;
-#endif /* 1 */
     Dwarf_Line_Context li_context; /* assoc Dwarf_Line_Context_s */
 
     /*  Set only on the actuals table of a two-level line table.

src/lib/libdwarf/dwarf_macro5.c

@@ -368,7 +368,7 @@ _dwarf_get_macro_ops_count_internal(Dwarf_Macro_Context macro_context,
                 Normally we don't see this, the end operator
                 signals end. */
             opslen = mdata - macro_context->mc_macro_ops;
-#if 0
+#if 0 /* Dropping a counterproductive test. */
             /*  This test fails when there are corrupted FORms
                 so we lose a really useful and precise error
                 message and get this useless message. */

src/lib/libdwarf/dwarf_object_detector.c

@@ -512,10 +512,6 @@ dwarf_object_detector_fd(int fd,
 
 int
 _dwarf_object_detector_fd_a(int fd,
-#if 0
-    void *   in_memory,
-    Dwarf_Unsigned in_mem_size,
-#endif
     unsigned *ftype,
     unsigned *endian,
     unsigned *offsetsize,
@@ -528,13 +524,7 @@ _dwarf_object_detector_fd_a(int fd,
     Dwarf_Unsigned filesize = 0;
     Dwarf_Unsigned remaininglen  = 0;
     int            res = 0;
-#if 0
-    char * memobj = (char *)in_memory;
 
-    if (memobj) {
-        filesize = in_mem_size;
-    } else
-#endif
     {
         res = _dwarf_seekr(fd,0,SEEK_END,&filesize);
         if (res != DW_DLV_OK) {