Merge pull request #8 from vbkaisetsu/patch-1

montanalow · web-flow · commit a5138a126c7a · 2023-12-28T17:46:09.000-06:00
Use f32::NAN as a missing value
diff --git a/src/dmatrix.rs b/src/dmatrix.rs
@@ -112,7 +112,7 @@ impl DMatrix {
         xgb_call!(xgboost_sys::XGDMatrixCreateFromMat(data.as_ptr(),
                                                       num_rows as xgboost_sys::bst_ulong,
                                                       (data.len() / num_rows) as xgboost_sys::bst_ulong,
-                                                      0.0, // TODO: can values be missing here?
+                                                      f32::NAN,
                                                       &mut handle))?;
         Ok(DMatrix::new(handle)?)
     }

Original file line number	Diff line number	Diff line change
`@@ -112,7 +112,7 @@ impl DMatrix {`
`112`	`112`	`xgb_call!(xgboost_sys::XGDMatrixCreateFromMat(data.as_ptr(),`
`113`	`113`	`num_rows as xgboost_sys::bst_ulong,`
`114`	`114`	`(data.len() / num_rows) as xgboost_sys::bst_ulong,`
`115`		`- 0.0, // TODO: can values be missing here?`
	`115`	`+ f32::NAN,`
`116`	`116`	`&mut handle))?;`
`117`	`117`	`Ok(DMatrix::new(handle)?)`
`118`	`118`	`}`