Trend indicator example does not use configuration

[ghostrider-05]

First of all, thank you for making this action! I've setup now this action with a trend indicator and thresholds, but I noticed that while using the example in the readme it does not use the vite config.

What worked for me was adding a checkout step to the report job and then the thresholds were used.

On a slightly related topic, can there an option / mode where a configuration is required to pass? Now I had to check the logs each time why the configuration was not found while it showed the run was successful

[davelosert]

Hey @ghostrider-05 , thank you for opening up this issue.

Good catch with the documentation. It's true that a checkout is required for the vite-config to be there so it can be considered. Happy to accept a PR for this 🙂 (else I'll see if I can fix this myself, soon).

On a slightly related topic, can there an option / mode where a configuration is required to pass? Now I had to check the logs each time why the configuration was not found while it showed the run was successful

That sounds reasonable. I guess it would also help to have the found config as output in the pull-request comment anyways (like, a confirmation that it was found and that the threshold's could be processed).

I was thinking an option:

• validate_config which can be set to false, warn and error, defaulting to false (for backwards compatability.
  • On warn, a coverage report is still generated, but a warning output for the action is generated and we add a note to the comment in the pr and the pr summary along the lines of weren't able to parse config at <path>
  • On error, it immediately fails the action with the error

WDYT?

[ghostrider-05]

A vite-config-validation (since there is a vite-config option) sounds good, same for the options of the validation. I see a PR open to improve the parsing, maybe that changes the example / readme (and it's fixed for me now :) ), I'll leave it to someone else to fix the example. I think the result of the action (if set to error) is probably enough, but someone else might find it useful.