Skip to content

Commit 5e0f2ad

Browse files
authored
🔀 Merge pull request #156 from davep/fix-compact
Fix a clash with the new `compact` property in Textual
2 parents 582a11b + 46274c1 commit 5e0f2ad

File tree

5 files changed

+21
-14
lines changed

5 files changed

+21
-14
lines changed

ChangeLog.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,12 @@
11
# Braindrop ChangeLog
22

3+
## v0.8.2
4+
5+
**Released: 2025-05-09**
6+
7+
- Fixed clash with Textual's newly-introduced `compact` reactive.
8+
([#156](https://github.com/davep/braindrop/pull/156))
9+
310
## v0.8.1
411

512
**Released: 2025-05-06**

requirements-dev.lock

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ httpcore==1.0.9
4545
# via httpx
4646
httpx==0.28.1
4747
# via braindrop
48-
humanize==4.12.2
48+
humanize==4.12.3
4949
# via braindrop
5050
identify==2.6.10
5151
# via pre-commit
@@ -82,7 +82,7 @@ nodeenv==1.9.1
8282
# via pre-commit
8383
packaging==25.0
8484
# via pytest
85-
platformdirs==4.3.7
85+
platformdirs==4.3.8
8686
# via textual
8787
# via virtualenv
8888
pluggy==1.5.0
@@ -107,7 +107,7 @@ rich==14.0.0
107107
# via textual-serve
108108
sniffio==1.3.1
109109
# via anyio
110-
textual==3.1.1
110+
textual==3.2.0
111111
# via braindrop
112112
# via textual-dev
113113
# via textual-enhanced
@@ -125,7 +125,7 @@ typing-extensions==4.13.2
125125
# via textual-dev
126126
uc-micro-py==1.0.3
127127
# via linkify-it-py
128-
virtualenv==20.30.0
128+
virtualenv==20.31.2
129129
# via pre-commit
130130
xdg-base-dirs==6.0.2
131131
# via braindrop

requirements.lock

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ httpcore==1.0.9
2121
# via httpx
2222
httpx==0.28.1
2323
# via braindrop
24-
humanize==4.12.2
24+
humanize==4.12.3
2525
# via braindrop
2626
idna==3.10
2727
# via anyio
@@ -36,7 +36,7 @@ mdit-py-plugins==0.4.2
3636
# via markdown-it-py
3737
mdurl==0.1.2
3838
# via markdown-it-py
39-
platformdirs==4.3.7
39+
platformdirs==4.3.8
4040
# via textual
4141
pygments==2.19.1
4242
# via rich
@@ -48,7 +48,7 @@ rich==14.0.0
4848
# via textual
4949
sniffio==1.3.1
5050
# via anyio
51-
textual==3.1.1
51+
textual==3.2.0
5252
# via braindrop
5353
# via textual-enhanced
5454
textual-enhanced==0.13.0

src/braindrop/app/screens/main.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -284,7 +284,7 @@ def on_mount(self) -> None:
284284
config = load_configuration()
285285
self.set_class(not config.details_visible, "details-hidden")
286286
self.query_one(Navigation).tags_by_count = config.show_tags_by_count
287-
self.query_one(RaindropsView).compact = config.compact_mode
287+
self.query_one(RaindropsView).compact_view = config.compact_mode
288288
self.load_data()
289289

290290
def watch_active_collection(self) -> None:
@@ -424,11 +424,11 @@ def action_details_command(self) -> None:
424424

425425
def action_compact_mode_command(self) -> None:
426426
"""Toggle the compact mode for the list of raindrops."""
427-
self.query_one(RaindropsView).compact = not self.query_one(
427+
self.query_one(RaindropsView).compact_view = not self.query_one(
428428
RaindropsView
429-
).compact
429+
).compact_view
430430
with update_configuration() as config:
431-
config.compact_mode = self.query_one(RaindropsView).compact
431+
config.compact_mode = self.query_one(RaindropsView).compact_view
432432

433433
@work
434434
async def action_search_command(self) -> None:

src/braindrop/app/widgets/raindrops_view.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ class RaindropsView(EnhancedOptionList):
143143
raindrops: var[Raindrops] = var(Raindrops)
144144
"""The list of raindrops being shown."""
145145

146-
compact: var[bool] = var(False)
146+
compact_view: var[bool] = var(False)
147147
"""Toggle to say if we should use a compact view or not."""
148148

149149
class Empty(Message):
@@ -154,7 +154,7 @@ def _add_raindrops(self) -> None:
154154
with self.preserved_highlight:
155155
self.clear_options().add_options(
156156
[
157-
RaindropView(raindrop, self.data, self.compact)
157+
RaindropView(raindrop, self.data, self.compact_view)
158158
for raindrop in self.raindrops
159159
]
160160
)
@@ -169,7 +169,7 @@ def watch_raindrops(self) -> None:
169169
"""React to the raindrops being changed."""
170170
self._add_raindrops()
171171

172-
def watch_compact(self) -> None:
172+
def watch_compact_view(self) -> None:
173173
"""React to the compact setting being toggled."""
174174
self._add_raindrops()
175175

0 commit comments

Comments
 (0)