Skip to content

Commit 23236e0

Browse files
committed
Migrated all actions to go 1.21
Go broke their backwards compatibility guarantee for multi-module workspaces that have different go directives in their go.mod. This prevents us from running tests on the library and awsrds store using any version below 1.21 because 1.21 places a toolchain directive in store/vault/go.mod which is parsed by running go commands in any other directory in the repo.
1 parent b917a46 commit 23236e0

File tree

5 files changed

+10
-30
lines changed

5 files changed

+10
-30
lines changed

.github/workflows/go.yml

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,9 @@ on:
99
jobs:
1010
build:
1111
runs-on: ubuntu-latest
12-
name: ${{ matrix.name }} - ${{ matrix.go }}
12+
name: ${{ matrix.name }} - 1.21
1313
strategy:
1414
matrix:
15-
go: ["1.18.x", "1.19.x", "1.20.x", "1.21.x"]
1615
dir: [".", "./store/awsrds", "./store/vault"]
1716
include:
1817
- dir: "."
@@ -21,18 +20,11 @@ jobs:
2120
name: "store/awsrds"
2221
- dir: "./store/vault"
2322
name: "store/vault"
24-
exclude:
25-
- dir: "./store/vault"
26-
go: "1.18.x"
27-
- dir: "./store/vault"
28-
go: "1.19.x"
29-
- dir: "./store/vault"
30-
go: "1.20.x"
3123
steps:
3224
- uses: actions/checkout@v4
3325
- uses: actions/setup-go@v4
3426
with:
35-
go-version: ${{ matrix.go }}
27+
go-version: 1.21
3628
cache-dependency-path: "${{ matrix.dir }}/go.sum"
3729
- name: Build
3830
run: go build -mod=readonly -v ./...

.github/workflows/lint.yml

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,9 @@ on:
99
jobs:
1010
lint:
1111
runs-on: ubuntu-latest
12-
name: ${{ matrix.name }} - ${{ matrix.go }}
12+
name: ${{ matrix.name }} - 1.21
1313
strategy:
1414
matrix:
15-
go: ["1.18.x", "1.19.x", "1.20.x", "1.21.x"]
1615
dir: [".", "./store/awsrds", "./store/vault"]
1716
include:
1817
- dir: "."
@@ -21,18 +20,11 @@ jobs:
2120
name: "store/awsrds"
2221
- dir: "./store/vault"
2322
name: "store/vault"
24-
exclude:
25-
- dir: "./store/vault"
26-
go: "1.18.x"
27-
- dir: "./store/vault"
28-
go: "1.19.x"
29-
- dir: "./store/vault"
30-
go: "1.20.x"
3123
steps:
3224
- uses: actions/checkout@v4
3325
- uses: actions/setup-go@v4
3426
with:
35-
go-version: ${{ matrix.go }}
27+
go-version: 1.21
3628
cache-dependency-path: "${{ matrix.dir }}/go.sum"
3729
- name: golangci-lint
3830
uses: golangci/golangci-lint-action@v3

.github/workflows/test.yml

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,9 @@ on:
99
jobs:
1010
lint:
1111
runs-on: ubuntu-latest
12-
name: ${{ matrix.name }} - ${{ matrix.go }}
12+
name: ${{ matrix.name }} - 1.21
1313
strategy:
1414
matrix:
15-
go: ["1.18.x", "1.19.x", "1.20.x", "1.21.x"]
1615
dir: [".", "./store/awsrds", "./store/vault"]
1716
include:
1817
- dir: "."
@@ -21,18 +20,11 @@ jobs:
2120
name: "store/awsrds"
2221
- dir: "./store/vault"
2322
name: "store/vault"
24-
exclude:
25-
- dir: "./store/vault"
26-
go: "1.18.x"
27-
- dir: "./store/vault"
28-
go: "1.19.x"
29-
- dir: "./store/vault"
30-
go: "1.20.x"
3123
steps:
3224
- uses: actions/checkout@v4
3325
- uses: actions/setup-go@v4
3426
with:
35-
go-version: ${{ matrix.go }}
27+
go-version: 1.21
3628
cache-dependency-path: "${{ matrix.dir }}/go.sum"
3729
- name: Test
3830
working-directory: ${{ matrix.dir }}

go.sum

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ github.com/creack/pty v1.1.7/go.mod h1:lj5s0c3V2DBrqTV7llrYr5NG6My20zk30Fl46Y7Do
99
github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
1010
github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
1111
github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc h1:U9qPSI2PIWSS1VwoXQT9A3Wy9MM3WgvqSxFWenqJduM=
12+
github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
1213
github.com/go-kit/log v0.1.0/go.mod h1:zbhenjAZHb184qTLMA9ZjW7ThYL0H2mk7Q6pNt4vbaY=
1314
github.com/go-logfmt/logfmt v0.5.0/go.mod h1:wCYkCAKZfumFQihp8CzCvQ3paCTfi41vtzG1KdI/P7A=
1415
github.com/go-sql-driver/mysql v1.7.1 h1:lUIinVbN1DY0xBg0eMOzmmtGoHwWBbvnWubQUrtU8EI=
@@ -92,6 +93,7 @@ github.com/pkg/errors v0.9.1 h1:FEBLx1zS214owpjy7qsBeixbURkuhQAwrK5UwLGTwt4=
9293
github.com/pkg/errors v0.9.1/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINEl0=
9394
github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
9495
github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2 h1:Jamvg5psRIccs7FGNTlIRMkT8wgtp5eCXdBlqhYGL6U=
96+
github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
9597
github.com/rogpeppe/go-internal v1.3.0/go.mod h1:M8bDsm7K2OlrFYOpmOWEs/qY81heoFRclV5y23lUDJ4=
9698
github.com/rs/xid v1.2.1/go.mod h1:+uKXf+4Djp6Md1KODXJxgGQPKngRmWyn10oCKFzNHOQ=
9799
github.com/rs/zerolog v1.13.0/go.mod h1:YbFCdg8HfsridGWAh22vktObvhZbQsZXe4/zB0OKkWU=
@@ -116,6 +118,7 @@ github.com/stretchr/testify v1.7.1/go.mod h1:6Fq8oRcR53rry900zMqJjRRixrwX3KX962/
116118
github.com/stretchr/testify v1.8.0/go.mod h1:yNjHg4UonilssWZ8iaSj1OCr/vHnekPRkoO+kdMU+MU=
117119
github.com/stretchr/testify v1.8.1/go.mod h1:w2LPCIKwWwSfY2zedu0+kehJoqGctiVI29o6fzry7u4=
118120
github.com/stretchr/testify v1.8.4 h1:CcVxjf3Q8PM0mHUKJCdn+eZZtm5yQwehR5yeSVQQcUk=
121+
github.com/stretchr/testify v1.8.4/go.mod h1:sz/lmYIOXD/1dqDmKjjqLyZ2RngseejIcXlSw2iwfAo=
119122
github.com/yuin/goldmark v1.4.13/go.mod h1:6yULJ656Px+3vBD8DxQVa3kxgyrAnzto9xy5taEt/CY=
120123
github.com/zenazn/goji v0.9.0/go.mod h1:7S9M489iMyHBNxwZnk9/EHS098H4/F6TATF2mIxtB1Q=
121124
go.uber.org/atomic v1.3.2/go.mod h1:gD2HeocX3+yG+ygLZcrzQJaqmWj9AIm7n08wl/qW/PE=

store/awsrds/go.sum

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ github.com/go-test/deep v1.1.0 h1:WOcxcdHcvdgThNXjw0t76K42FXTU7HpNQWHpA2HHNlg=
2828
github.com/gofrs/uuid v4.0.0+incompatible h1:1SD/1F5pU8p29ybwgQSwpQk+mwdRrXCYuPhW6m+TnJw=
2929
github.com/gofrs/uuid v4.0.0+incompatible/go.mod h1:b2aQJv3Z4Fp6yNu3cdSllBxTCLRxnplIgP/c0N/04lM=
3030
github.com/google/go-cmp v0.6.0 h1:ofyhxvXcZhMsU5ulbFiLKl/XBFqE1GSq7atu8tAmTRI=
31+
github.com/google/go-cmp v0.6.0/go.mod h1:17dUlkBOakJ0+DkrSSNjCkIjxS6bF9zb3elmeNGIjoY=
3132
github.com/google/renameio v0.1.0/go.mod h1:KWCgfxg9yswjAJkECMjeO8J8rahYeXnNhOm40UhjYkI=
3233
github.com/jackc/chunkreader v1.0.0/go.mod h1:RT6O25fNZIuasFJRyZ4R/Y2BbhasbmZXF9QQ7T3kePo=
3334
github.com/jackc/chunkreader/v2 v2.0.0/go.mod h1:odVSm741yZoC3dpHEUXIqA9tQRhFrgOHwnPIn9lDKlk=

0 commit comments

Comments
 (0)