Skip to content

Commit 9839c12

Browse files
authored
Add 4.14.1 as compiler version in CI (#550)
* Add 4.14.1 as compiler version * Pin srr overriding 0.3.1 * Update server-reason-react hash with melange5 * Add quickjs pin * Update quickjs pin with 4.14 * Remove template and use pin * Update pins * add devsetup * REORDER * Only pin server-reason-react, not quicky * Same version for server-rr * Trying pin after install??? * El truco del almendruco * Use template, please work, I'm crying * Upload only if if: matrix.os == 'ubuntu-20.04' && matrix.ocaml-compiler == '4.14.1' * Don't upload * Only for 4.14
1 parent 4424da4 commit 9839c12

File tree

4 files changed

+8
-9
lines changed

4 files changed

+8
-9
lines changed

.github/workflows/ci.yml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ jobs:
2727
matrix:
2828
os: [ubuntu-20.04, macos-latest] # Missing windows-latest
2929
ocaml-compiler:
30+
- 4.14.1
3031
- 5.2.0
3132

3233
runs-on: ${{ matrix.os }}
@@ -99,12 +100,13 @@ jobs:
99100

100101
- name: Upload artifacts for ${{ matrix.os }}
101102
uses: actions/upload-artifact@v4
103+
if: matrix.ocaml-compiler == '4.14.1'
102104
with:
103105
name: ${{ matrix.os }}
104106
path: _build/default/packages/bin/bin.exe
105107

106108
- name: Upload runtime artifacts for @davesnx/styled-ppx/runtime
107-
if: matrix.os == 'ubuntu-20.04'
109+
if: matrix.os == 'ubuntu-20.04' && matrix.ocaml-compiler == '4.14.1'
108110
uses: actions/upload-artifact@v4
109111
with:
110112
name: runtime-rescript
@@ -127,9 +129,6 @@ jobs:
127129
path: node_modules
128130
key: npm-${{ matrix.os }}-${{ hashFiles('package.json') }}
129131

130-
- name: Grant permission to run ppx
131-
run: chmod +x _build/default/packages/bin/bin.exe
132-
133132
- name: Run E2E tests
134133
run: make test-e2e
135134

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ create-switch: ## Create opam switch
4646

4747
.PHONY: install
4848
install: ## Install project dependencies
49-
opam install . --deps-only --with-test -y
49+
opam install . --deps-only --with-test --working-dir . -y
5050
npm install
5151

5252
.PHONY: init

styled-ppx.opam

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,5 +47,5 @@ depexts: [
4747
]
4848

4949
pin-depends: [
50-
["server-reason-react.0.3.1" "git+https://github.com/ml-in-barcelona/server-reason-react#ea16c107cd41a2e9d01dff358239eec37046951f"]
51-
]
50+
["server-reason-react.0.3.1" "git+https://github.com/ml-in-barcelona/server-reason-react#ce006ee5ad5562eee617a4c713b1efa317dc2aab"]
51+
]

styled-ppx.opam.template

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,5 @@ depexts: [
33
]
44

55
pin-depends: [
6-
["server-reason-react.0.3.1" "git+https://github.com/ml-in-barcelona/server-reason-react#ea16c107cd41a2e9d01dff358239eec37046951f"]
7-
]
6+
["server-reason-react.0.3.1" "git+https://github.com/ml-in-barcelona/server-reason-react#ce006ee5ad5562eee617a4c713b1efa317dc2aab"]
7+
]

0 commit comments

Comments
 (0)