Skip to content

Commit bf7d40d

Browse files
benoitmaillardmhaessig
authored andcommitted
8356751: IGV: clean up redundant field _should_send_method
Co-authored-by: Manuel Hässig <[email protected]> Reviewed-by: mhaessig, thartmann, dfenacci
1 parent 5ae32c4 commit bf7d40d

File tree

2 files changed

+6
-11
lines changed

2 files changed

+6
-11
lines changed

src/hotspot/share/opto/idealGraphPrinter.cpp

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,6 @@ void IdealGraphPrinter::init(const char* file_name, bool use_multiple_files, boo
155155
// in the mach where kill projections have no users but should
156156
// appear in the dump.
157157
_traverse_outs = true;
158-
_should_send_method = true;
159158
_output = nullptr;
160159
buffer[0] = 0;
161160
_depth = 0;
@@ -300,13 +299,11 @@ void IdealGraphPrinter::print_inline_tree(InlineTree *tree) {
300299
void IdealGraphPrinter::print_inlining() {
301300

302301
// Print inline tree
303-
if (_should_send_method) {
304-
InlineTree *inlineTree = C->ilt();
305-
if (inlineTree != nullptr) {
306-
print_inline_tree(inlineTree);
307-
} else {
308-
// print this method only
309-
}
302+
InlineTree *inlineTree = C->ilt();
303+
if (inlineTree != nullptr) {
304+
print_inline_tree(inlineTree);
305+
} else {
306+
// print this method only
310307
}
311308
}
312309

@@ -382,7 +379,6 @@ void IdealGraphPrinter::begin_method() {
382379

383380
tail(PROPERTIES_ELEMENT);
384381

385-
_should_send_method = true;
386382
this->_current_method = method;
387383

388384
_xml->flush();
@@ -975,7 +971,7 @@ void IdealGraphPrinter::print_graph(const char* name, const frame* fr) {
975971
// Print current ideal graph
976972
void IdealGraphPrinter::print(const char* name, Node* node, GrowableArray<const Node*>& visible_nodes, const frame* fr) {
977973

978-
if (!_current_method || !_should_send_method || node == nullptr) return;
974+
if (!_current_method || node == nullptr) return;
979975

980976
if (name == nullptr) {
981977
stringStream graph_name;

src/hotspot/share/opto/idealGraphPrinter.hpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,6 @@ class IdealGraphPrinter : public CHeapObj<mtCompiler> {
110110
ciMethod *_current_method;
111111
int _depth;
112112
char buffer[2048];
113-
bool _should_send_method;
114113
PhaseChaitin* _chaitin;
115114
bool _traverse_outs;
116115
Compile *C;

0 commit comments

Comments
 (0)