Manipulating classpath items should preserve item order

jeantil · jeantil · commit cb79d5723e61 · 2025-08-17T08:17:39.000+02:00
`getClasspathElements` computes the compilation and test compilation classpath from `MavenProject#getCompileClasspathElements` which is a `List<String>`. Transforming from the ordered `List<String>` into an unordered `Hashset<File>` can change the order of classpath elements. While this didn't cause a compilation issue in my case it could. It did break the [develocity cache key computation](https://develocity.apache.org/c/unuozmm6ecqpc/nusnauq3l6a6u/goal-inputs?expanded=WyJuemRibm96bGFrZ2FnLWNsYXNzcGF0aGVsZW1lbnRzIiwibnpkYm5vemxha2dhZy1jbGFzc3BhdGhFbGVtZW50cy0wLWZpbGUtb3JkZXIiXQ) I'm using to improve Apache James build times.
diff --git a/src/main/java/util/FileUtils.java b/src/main/java/util/FileUtils.java
@@ -36,7 +36,7 @@ public static File fileOf(File f, boolean canonical) throws Exception {
   }
 
   public static Set<File> fromStrings(Collection<String> s) {
-    return s.stream().map(File::new).collect(Collectors.toSet());
+    return s.stream().map(File::new).collect(Collectors.toCollection(TreeSet::new));
   }
 
   public static String toMultiPath(Collection<File> paths) {

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ public static File fileOf(File f, boolean canonical) throws Exception {`
`36`	`36`	`}`
`37`	`37`
`38`	`38`	`public static Set<File> fromStrings(Collection<String> s) {`
`39`		`- return s.stream().map(File::new).collect(Collectors.toSet());`
	`39`	`+ return s.stream().map(File::new).collect(Collectors.toCollection(TreeSet::new));`
`40`	`40`	`}`
`41`	`41`
`42`	`42`	`public static String toMultiPath(Collection<File> paths) {`