✨ allow to create span for opentelemetry at level info with feature flag tracing_level_info

FIX #126

Author: davidB

examples/load/src/main.rs

@@ -2,7 +2,7 @@ use std::time::Instant;
 
 use memory_stats::memory_stats;
 use tracing::field::Empty;
-use tracing_opentelemetry_instrumentation_sdk::TRACING_TARGET;
+use tracing_opentelemetry_instrumentation_sdk::otel_trace_span;
 
 #[tokio::main]
 async fn main() -> Result<(), Box<dyn std::error::Error>> {
@@ -25,8 +25,7 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
             );
         }
         for _i in 1..10000 {
-            let _span = tracing::trace_span!(
-                target: TRACING_TARGET,
+            let _span = otel_trace_span!(
                 "Load",
                 http.request.method = "GET",
                 http.route = Empty,

tonic-tracing-opentelemetry/src/tracing_opentelemetry_instrumentation_sdk/http/grpc_client.rs

@@ -1,7 +1,7 @@
 use std::error::Error;
 
 use super::super::http::{extract_service_method, http_host, user_agent};
-use super::super::TRACING_TARGET;
+use super::super::otel_trace_span;
 use tracing::field::Empty;
 
 use super::grpc_update_span_from_response;
@@ -10,8 +10,7 @@ use super::grpc_update_span_from_response;
 //TODO create similar but with tonic::Request<B> ?
 pub fn make_span_from_request<B>(req: &http::Request<B>) -> tracing::Span {
     let (service, method) = extract_service_method(req.uri());
-    tracing::trace_span!(
-        target: TRACING_TARGET,
+    otel_trace_span!(
         "GRPC request",
         http.user_agent = %user_agent(req),
         otel.name = format!("{service}/{method}"),

tonic-tracing-opentelemetry/src/tracing_opentelemetry_instrumentation_sdk/http/grpc_server.rs

@@ -1,4 +1,4 @@
-use super::super::{BoxError, TRACING_TARGET};
+use super::super::{otel_trace_span, BoxError};
 use super::{extract_service_method, http_host, user_agent};
 use tracing::field::Empty;
 
@@ -8,8 +8,7 @@ use super::grpc_update_span_from_response;
 /// see [Semantic Conventions for gRPC | OpenTelemetry](https://opentelemetry.io/docs/specs/semconv/rpc/grpc/#grpc-status)
 pub fn make_span_from_request<B>(req: &http::Request<B>) -> tracing::Span {
     let (service, method) = extract_service_method(req.uri());
-    tracing::trace_span!(
-        target: TRACING_TARGET,
+    otel_trace_span!(
         "GRPC request",
         http.user_agent = %user_agent(req),
         otel.name = format!("{service}/{method}"),

tonic-tracing-opentelemetry/src/tracing_opentelemetry_instrumentation_sdk/http/http_server.rs

@@ -1,7 +1,7 @@
 use std::error::Error;
 
+use super::super::otel_trace_span;
 use super::super::span_type::SpanType;
-use super::super::TRACING_TARGET;
 use super::{http_flavor, http_host, http_method, url_scheme, user_agent};
 use tracing::field::Empty;
 
@@ -10,8 +10,7 @@ pub fn make_span_from_request<B>(req: &http::Request<B>) -> tracing::Span {
     // [opentelemetry-specification/.../span-general.md](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/span-general.md)
     // Can not use const or opentelemetry_semantic_conventions::trace::* for name of records
     let http_method = http_method(req.method());
-    tracing::trace_span!(
-        target: TRACING_TARGET,
+    otel_trace_span!(
         "HTTP request",
         http.request.method = %http_method,
         http.route = Empty, // to set by router of "webframework" after

tonic-tracing-opentelemetry/src/tracing_opentelemetry_instrumentation_sdk/mod.rs

@@ -13,6 +13,12 @@ use opentelemetry::Context;
 /// tracing's target used by instrumentation library to create span
 pub const TRACING_TARGET: &str = "otel::tracing";
 
+#[cfg(not(feature = "tracing_level_info"))]
+pub const TRACING_LEVEL: tracing::Level = tracing::Level::TRACE;
+
+#[cfg(feature = "tracing_level_info")]
+pub const TRACING_LEVEL: tracing::Level = tracing::Level::INFO;
+
 // const SPAN_NAME_FIELD: &str = "otel.name";
 // const SPAN_KIND_FIELD: &str = "otel.kind";
 // const SPAN_STATUS_CODE_FIELD: &str = "otel.status_code";
@@ -22,6 +28,38 @@ pub const TRACING_TARGET: &str = "otel::tracing";
 // const FIELD_EXCEPTION_STACKTRACE: &str = "exception.stacktrace";
 // const HTTP_TARGET: &str = opentelemetry_semantic_conventions::trace::HTTP_TARGET.as_str();
 
+/// Constructs a span for the target `TRACING_TARGET` with the level `TRACING_LEVEL`.
+///
+/// [Fields] and [attributes] are set using the same syntax as the [`tracing::span!`]
+/// macro.
+// #[macro_export]
+macro_rules! otel_trace_span {
+    (parent: $parent:expr, $name:expr, $($field:tt)*) => {
+        tracing::span!(
+            target: $crate::tracing_opentelemetry_instrumentation_sdk::TRACING_TARGET,
+            parent: $parent,
+            $crate::tracing_opentelemetry_instrumentation_sdk::TRACING_LEVEL,
+            $name,
+            $($field)*
+        )
+    };
+    (parent: $parent:expr, $name:expr) => {
+        $crate::otel_trace_span!(parent: $parent, $name,)
+    };
+    ($name:expr, $($field:tt)*) => {
+        tracing::span!(
+            target: $crate::tracing_opentelemetry_instrumentation_sdk::TRACING_TARGET,
+            $crate::tracing_opentelemetry_instrumentation_sdk::TRACING_LEVEL,
+            $name,
+            $($field)*
+        )
+    };
+    ($name:expr) => {
+        $crate::otel_trace_span!($name,)
+    };
+}
+pub(crate) use otel_trace_span;
+
 #[inline]
 #[must_use]
 pub fn find_current_context() -> Context {

tracing-opentelemetry-instrumentation-sdk/Cargo.toml

@@ -28,3 +28,5 @@ rstest = "0.18"
 [features]
 default = []
 http = ["dep:http"]
+# to use level `info` instead of `trace` to create otel span
+tracing_level_info = []

tracing-opentelemetry-instrumentation-sdk/README.md

@@ -49,8 +49,7 @@ Use `tracing::instrumented` (no propagation & no update on response)
 fn make_otel_span(db_operation: &str) -> tracing::Span {
     // NO parsing of statement to extract information, not recommended by Specification and time-consuming
     // warning: providing the statement could leek information
-    tracing::trace_span!(
-        target: tracing_opentelemetry_instrumentation_sdk::TRACING_TARGET,
+    tracing_opentelemetry_instrumentation_sdk::otel_trace_span!(
         "DB request",
         db.system = "postgresql",
         // db.statement = stmt,

tracing-opentelemetry-instrumentation-sdk/src/http/grpc_client.rs

@@ -1,7 +1,7 @@
 use std::error::Error;
 
 use crate::http::{extract_service_method, http_host, user_agent};
-use crate::TRACING_TARGET;
+use crate::otel_trace_span;
 use tracing::field::Empty;
 
 use super::grpc_update_span_from_response;
@@ -10,8 +10,7 @@ use super::grpc_update_span_from_response;
 //TODO create similar but with tonic::Request<B> ?
 pub fn make_span_from_request<B>(req: &http::Request<B>) -> tracing::Span {
     let (service, method) = extract_service_method(req.uri());
-    tracing::trace_span!(
-        target: TRACING_TARGET,
+    otel_trace_span!(
         "GRPC request",
         http.user_agent = %user_agent(req),
         otel.name = format!("{service}/{method}"),

tracing-opentelemetry-instrumentation-sdk/src/http/grpc_server.rs

@@ -1,5 +1,5 @@
 use crate::http::{extract_service_method, http_host, user_agent};
-use crate::{BoxError, TRACING_TARGET};
+use crate::{otel_trace_span, BoxError};
 use tracing::field::Empty;
 
 use super::grpc_update_span_from_response;
@@ -8,8 +8,7 @@ use super::grpc_update_span_from_response;
 /// see [Semantic Conventions for gRPC | OpenTelemetry](https://opentelemetry.io/docs/specs/semconv/rpc/grpc/#grpc-status)
 pub fn make_span_from_request<B>(req: &http::Request<B>) -> tracing::Span {
     let (service, method) = extract_service_method(req.uri());
-    tracing::trace_span!(
-        target: TRACING_TARGET,
+    otel_trace_span!(
         "GRPC request",
         http.user_agent = %user_agent(req),
         otel.name = format!("{service}/{method}"),

tracing-opentelemetry-instrumentation-sdk/src/http/http_server.rs

@@ -1,17 +1,16 @@
 use std::error::Error;
 
 use crate::http::{http_flavor, http_host, http_method, url_scheme, user_agent};
+use crate::otel_trace_span;
 use crate::span_type::SpanType;
-use crate::TRACING_TARGET;
 use tracing::field::Empty;
 
 pub fn make_span_from_request<B>(req: &http::Request<B>) -> tracing::Span {
     // [semantic-conventions/.../http-spans.md](https://github.com/open-telemetry/semantic-conventions/blob/v1.25.0/docs/http/http-spans.md)
     // [semantic-conventions/.../general/attributes.md](https://github.com/open-telemetry/semantic-conventions/blob/v1.25.0/docs/general/attributes.md)
     // Can not use const or opentelemetry_semantic_conventions::trace::* for name of records
     let http_method = http_method(req.method());
-    tracing::trace_span!(
-        target: TRACING_TARGET,
+    otel_trace_span!(
         "HTTP request",
         http.request.method = %http_method,
         http.route = Empty, // to set by router of "webframework" after