add terminate method in globalPlugin class to free an instance correctly.

update readme and buildVars

Author: davidacm

addon/globalPlugins/beepKeyboard.py

@@ -25,7 +25,6 @@ def _reportToggleKey(self):
 	else: tones.beep(1000,40)
 	if config.conf['beepKeyboard']['announceToggleStatus']: origReportToggleKey(self)
 
-
 class BeepKeyboardSettingsPanel(gui.SettingsPanel):
 	# Translators: This is the label for the beepKeyboard  settings category in NVDA Settings screen.
 	title = _("Beep keyboard")
@@ -61,19 +60,31 @@ class GlobalPlugin(globalPluginHandler.GlobalPlugin):
 	def __init__(self):
 		super(globalPluginHandler.GlobalPlugin, self).__init__()
 		gui.settingsDialogs.NVDASettingsDialog.categoryClasses.append(BeepKeyboardSettingsPanel)
-		self.setExternalReportToggleStatus()
+		self.setExternalReportToggleStatus(config.conf['beepKeyboard']['beepToggleKeyChanges'])
 		if hasattr(config, "post_configProfileSwitch"):
-			config.post_configProfileSwitch.register(self.setExternalReportToggleStatus)
+			config.post_configProfileSwitch.register(self.handleConfigProfileSwitch)
 		else:
-			config.configProfileSwitched.register(self.setExternalReportToggleStatus)
+			config.configProfileSwitched.register(self.handleConfigProfileSwitch)
 
 	def event_typedCharacter(self, obj, nextHandler, ch):
 		nextHandler()
 		if ((config.conf['beepKeyboard']['beepUpperWithCapsLock'] and winUser.getKeyState(winUser.VK_CAPITAL)&1 and ch.isupper())
 		or (config.conf['beepKeyboard']['beepCharacterWithShift'] and (winUser.getKeyState(winUser.VK_LSHIFT) &32768 or winUser.getKeyState(winUser.VK_RSHIFT) &32768))):
 			tones.beep(3000,40)
 
-	def setExternalReportToggleStatus(self):
-		if config.conf['beepKeyboard']['beepToggleKeyChanges']:
+	def setExternalReportToggleStatus(self, flag):
+		if flag:
 			keyboardHandler.KeyboardInputGesture._reportToggleKey = _reportToggleKey
 		else: keyboardHandler.KeyboardInputGesture._reportToggleKey = origReportToggleKey
+
+	def handleConfigProfileSwitch(self):
+		self.setExternalReportToggleStatus(config.conf['beepKeyboard']['beepToggleKeyChanges'])
+
+	def terminate(self):
+		super(GlobalPlugin, self).terminate()
+		self.setExternalReportToggleStatus(False)
+		gui.settingsDialogs.NVDASettingsDialog.categoryClasses.remove(BeepKeyboardSettingsPanel)
+		if hasattr(config, "post_configProfileSwitch"):
+			config.post_configProfileSwitch.unregister(self.handleConfigProfileSwitch)
+		else:
+			config.configProfileSwitched.unregister(self.handleConfigProfileSwitch)

beepKeyboard.pot

@@ -6,9 +6,9 @@
 #, fuzzy
 msgid ""
 msgstr ""
-"Project-Id-Version: 'beepKeyboard' '0.1b1'\n"
+"Project-Id-Version: 'beepKeyboard' '0.1b2'\n"
 "Report-Msgid-Bugs-To: '[email protected]'\n"
-"POT-Creation-Date: 2019-04-12 20:20-0600\n"
+"POT-Creation-Date: 2019-04-13 09:13-0600\n"
 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
 "Language-Team: LANGUAGE <[email protected]>\n"
@@ -20,27 +20,27 @@ msgstr ""
 #. Translators: This is the label for the beepKeyboard  settings category in NVDA Settings screen.
 #. Add-on summary, usually the user visible name of the addon.
 #. Translators: Summary for this add-on to be shown on installation and add-on information.
-#: addon\globalPlugins\beepKeyboard.py:31 buildVars.py:17
+#: addon\globalPlugins\beepKeyboard.py:30 buildVars.py:17
 msgid "Beep keyboard"
 msgstr ""
 
 #. Translators: label for a checkbox option in the settings panel.
-#: addon\globalPlugins\beepKeyboard.py:36
+#: addon\globalPlugins\beepKeyboard.py:35
 msgid "Beep for uppercases  when &caps lock is on"
 msgstr ""
 
 #. Translators: label for a checkbox option in the settings panel.
-#: addon\globalPlugins\beepKeyboard.py:39
+#: addon\globalPlugins\beepKeyboard.py:38
 msgid "Beep for typed characters when &shift is pressed"
 msgstr ""
 
 #. Translators: label for a checkbox option in the settings panel.
-#: addon\globalPlugins\beepKeyboard.py:42
+#: addon\globalPlugins\beepKeyboard.py:41
 msgid "Beep for &toggle keys changes"
 msgstr ""
 
 #. Translators: label for a checkbox option in the settings panel.
-#: addon\globalPlugins\beepKeyboard.py:45
+#: addon\globalPlugins\beepKeyboard.py:44
 msgid ""
 "&Announce toggle keys changes (if Beep for toggle keys changes is disabled "
 "NVDA will have the original behavior)"

buildVars.py

@@ -19,7 +19,7 @@
 	# Translators: Long description to be shown for this add-on on add-on information from add-ons manager
 	"addon_description" : _("""This add-on beeps with some keyboard events."""),
 	# version
-	"addon_version" : "0.1b1",
+	"addon_version" : "0.1b2",
 	# Author(s)
 	"addon_author" : u"David CM <[email protected]>",
 	# URL for the add-on documentation support

readme.md

@@ -3,7 +3,7 @@ This add-on allows the user to configure NVDA to beeps with some keyboard events
 
 Copyright (C) 2019 David CM <[email protected]>
 
-This package is distributed under the terms of the GNU General Public License, version 2 or later. Please see the file COPYING.txt for further details.
+This package is distributed under the terms of the GNU General Public License, version 2 or later.
 
 ## Features