Skip to content

require('astravel') broken due to @babel/runtime dependencyΒ #34

@mureinik

Description

@mureinik

astravel@0.6.1 added a dependency on @babel/runtime but didn't declare it as a dependency in package.json, only as a devDependency. As a result, astravel cannot be used with a require statement (at least not out of the box. It will of course work if you manually install the dependency). Minimal reproducer:

mureinik@computer:~/src/git$ mkdir astravel-require

mureinik@computer:~/src/git$ cd astravel-require/

mureinik@computer:~/src/git/astravel-require$ npm init -y
Wrote to /home/mureinik/src/git/astravel-require/package.json:

{
  "name": "astravel-require",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "keywords": [],
  "author": "",
  "license": "ISC"
}



mureinik@computer:~/src/git/astravel-require$ npm install astravel

added 1 package, and audited 2 packages in 484ms

found 0 vulnerabilities
npm notice
npm notice New patch version of npm available! 8.19.2 -> 8.19.3
npm notice Changelog: https://github.com/npm/cli/releases/tag/v8.19.3
npm notice Run npm install -g npm@8.19.3 to update!
npm notice

mureinik@computer:~/src/git/astravel-require$ node -e "require('astravel')"
node:internal/modules/cjs/loader:988
  throw err;
  ^

Error: Cannot find module '@babel/runtime/helpers/interopRequireDefault'
Require stack:
- /home/mureinik/src/git/astravel-require/node_modules/astravel/dist/require/defaultTraveler.js
- /home/mureinik/src/git/astravel-require/node_modules/astravel/dist/require/astravel.js
- /home/mureinik/src/git/astravel-require/[eval]
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:985:15)
    at Function.Module._load (node:internal/modules/cjs/loader:833:27)
    at Module.require (node:internal/modules/cjs/loader:1057:19)
    at require (node:internal/modules/cjs/helpers:103:18)
    at Object.<anonymous> (/home/mureinik/src/git/astravel-require/node_modules/astravel/dist/require/defaultTraveler.js:3:30)
    at Module._compile (node:internal/modules/cjs/loader:1155:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1209:10)
    at Module.load (node:internal/modules/cjs/loader:1033:32)
    at Function.Module._load (node:internal/modules/cjs/loader:868:12)
    at Module.require (node:internal/modules/cjs/loader:1057:19) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/home/mureinik/src/git/astravel-require/node_modules/astravel/dist/require/defaultTraveler.js',
    '/home/mureinik/src/git/astravel-require/node_modules/astravel/dist/require/astravel.js',
    '/home/mureinik/src/git/astravel-require/[eval]'
  ]
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions