Skip to content

Commit 0e71cff

Browse files
authored
documentation tidy-up
1 parent 71f089e commit 0e71cff

File tree

1 file changed

+22
-22
lines changed

1 file changed

+22
-22
lines changed

README.md

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -15,27 +15,26 @@
1515

1616
## Module description
1717

18-
This Module uses srvrco's getssl bash script to obtain SSL-Certificates.
18+
This Module uses srvrco's getssl bash script to obtain SSL certificates.
1919
The certificates can be used for various protocols like https, smtps, ldaps and so on.
20-
To get more information about srvrco's getssl script go to his site.
21-
[getssl](https://github.com/srvrco/getssl)
20+
For more information about the getssl script, [visit its site](https://github.com/srvrco/getssl)
2221

23-
You can use this module only to install getssl script and configure it by yourself or
24-
configure all SSL relevant parameters and let this module obtain SSL certificates for you.
22+
You can use this module to just install getssl script and configure it by yourself, or
23+
you can configure all relevant parameters and let this module obtain SSL certificates for you.
2524

2625
## Setup
2726

2827
### What getssl affects
2928

3029
This module creates folders and files under the base directory
3130

32-
* The base directory is `/opt/getssl/`
31+
* The base directory is `/opt/getssl/` unless overridden with the `base_dir` parameter
3332
* For each domain it creates new sub directory `$base_dir/example.com/`
3433

3534
### Setup Requirements
3635

3736
If you want to use this module you have to install `curl`.
38-
If you don't want to install curl manually you can install it with this module.
37+
If you don't want to install curl manually you can install it with this module by setting the `manage_packages` parameter to true.
3938

4039
### Beginning with getssl
4140

@@ -50,29 +49,29 @@ class { 'getssl': }
5049
### Configuring global configuration file
5150

5251
`getssl` is modular so you can set global configuration parameters
53-
and the local parameters will overwrite the global ones.
54-
To configure the global configuration parameters the following code is can be
55-
used to ensure a minimal configuration.
52+
and the local per-domain parameters will overwrite the global ones.
53+
To configure the global configuration parameters the following code is sufficient
54+
for a minimal configuration.
5655

5756
``` puppet
5857
class { 'getssl':
59-
account_mail => '[email protected]',
60-
production => true,
58+
account_mail => '[email protected]',
6159
manage_packages => true,
6260
}
6361
```
6462
### Configure domain specific parameters
6563

66-
To obtain a certificate for your domain use the defined function.
67-
Following example is for nginx. But you can yous your favorite webserver
68-
e.g apache2 or lighttp.
64+
To obtain a certificate for your domain use the domain class.
65+
The following example is for Apache 2, but you can easily amend the configuration for your favourite webserver
66+
e.g. nginx or lighttp.
6967

7068
``` puppet
7169
getssl::domain { 'example.com':
72-
acl => ['/var/nginx/default],
70+
acl => ['/usr/local/www/example.com/htdocs/.well-known/acme-challenge],
7371
sub_domains => ['www.example.com', 'foo.example.com', 'bar.example.com'],
7472
domain_check_remote => true,
7573
production => true,
74+
domain_reload_command => 'systemctl restart apache2',
7675
}
7776
```
7877

@@ -88,21 +87,22 @@ This example tries to get a certificate for:
8887
This class is used to install getssl on your server and configure the global parameters.
8988

9089
``` puppet
91-
class{ 'getssl': }
90+
class { 'getssl': }
9291
```
9392
**Description of parameters can be found in the appropriate .pp files**
9493

9594
### Public defined types
9695

97-
The defined type `getssl::domain` is used to configure domain specific parameters. This type
96+
The defined type `getssl::domain` is used to configure domain-specific parameters. This type
9897
tries to obtain the certificates from letsencrypt.
9998

10099
**Description of parameters can be found in the appropriate .pp files**
101100

102101
## Limitations
103102

104-
This module ist testet on Debian 8 Stable. Can test it under a different version or OS please
105-
make an issue to disscuse.
103+
This module has been tested on Debian 8 and 9 stable.
104+
If you have tested it successfully with other versions or OS, please create an issue to discuss.
105+
If changes were needed to support your OS, please submit a pull request.
106106

107107
> **Note**: There are some limitations to obtain SSL certificates by LetsEncrypt themselves.
108108
Please also read the documentation of LetsEncrypt.
@@ -111,9 +111,9 @@ Please also read the documentation of LetsEncrypt.
111111
## Development
112112

113113
If you want to make improvements open a issue or make a pull request.
114-
I will add few tests to this module but i am new to this so it will take time.
114+
I will add few tests to this module but I am new to this so it will take time.
115115

116116
## Appendix
117117

118-
A big thanks to srvrco for his perfect bash written shell script. Thank you!
118+
Big thanks to Daniel Thielking, the original author of this module, and to srvrco for his perfect bash written shell script. Thank you!
119119
Thanks to the community of LetsEncrypt.

0 commit comments

Comments
 (0)