Skip to content

Commit e162997

Browse files
committed
Refactor component to be more functional
1 parent 820ff46 commit e162997

File tree

14 files changed

+529
-840
lines changed

14 files changed

+529
-840
lines changed

.eslintrc

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,9 @@ rules:
1111
semi:
1212
- 2
1313
- always
14-
react/no-did-update-set-state:
15-
- 0
14+
react/jsx-boolean-value:
15+
- 2
16+
- always
1617
react/sort-comp:
1718
- 2
1819
- order

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ disabled |boolean |Disabled or not
7777
maxValue |number |Maximum value it can accept
7878
minValue |number |Minimum value it can accept
7979
name |string |Name of `form` input
80-
onChange |Function |`onChange` callback
80+
onChange |Function |`onChange` callback (required)
8181
step |number |Increment/decrement value
8282
value |number |Current value
8383
values |Object |Current range of values

example/js/App.js

Lines changed: 36 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -7,26 +7,46 @@ class App extends React.Component {
77

88
this.state = {
99
value: 5,
10+
value2: null,
11+
value3: 10,
1012
values: {
1113
min: 5,
1214
max: 10,
1315
},
16+
values2: {
17+
min: null,
18+
max: null,
19+
}
1420
};
1521
}
1622

1723
handleValuesChange(component, values) {
18-
console.log(values);
19-
2024
this.setState({
2125
values: values,
2226
});
2327
}
2428

29+
handleValues2Change(component, values) {
30+
this.setState({
31+
values2: values,
32+
});
33+
}
34+
2535
handleValueChange(component, value) {
26-
console.log(value);
36+
this.setState({
37+
value: value || 0,
38+
});
39+
}
40+
41+
handleValue2Change(component, value) {
42+
this.setState({
43+
value2: value || 0,
44+
});
45+
}
2746

47+
handleValue3Change(component, value) {
2848
this.setState({
29-
value: value,
49+
value3: value || 0,
3050
});
3151
}
3252

@@ -42,34 +62,39 @@ class App extends React.Component {
4262
<InputRange
4363
maxValue={20}
4464
minValue={0}
45-
values={this.state.values}
46-
onChange={this.handleValuesChange.bind(this)}
65+
value={this.state.value}
66+
onChange={this.handleValueChange.bind(this)}
4767
/>
4868

4969
<InputRange
5070
maxValue={20}
5171
minValue={0}
52-
defaultValues={defaultValues}
72+
values={this.state.values}
73+
onChange={this.handleValuesChange.bind(this)}
5374
/>
5475

5576
<InputRange
5677
maxValue={20}
5778
minValue={0}
58-
value={this.state.value}
59-
onChange={this.handleValueChange.bind(this)}
79+
value={this.state.value2}
80+
defaultValue={defaultValue}
81+
onChange={this.handleValue2Change.bind(this)}
6082
/>
6183

6284
<InputRange
6385
maxValue={20}
6486
minValue={0}
65-
defaultValue={defaultValue}
87+
values={this.state.values2}
88+
defaultValues={defaultValues}
89+
onChange={this.handleValues2Change.bind(this)}
6690
/>
6791

6892
<InputRange
6993
maxValue={20}
7094
minValue={0}
7195
disabled={true}
72-
defaultValue={defaultValue}
96+
value={this.state.value3}
97+
onChange={this.handleValue3Change.bind(this)}
7398
/>
7499
</form>
75100
);

0 commit comments

Comments
 (0)