Clippy

Author: joehoyle

src/zend/globals.rs

@@ -225,16 +225,16 @@ impl<'a> SapiHeader {
     pub fn as_str(&'a self) -> &'a str {
         unsafe {
             let slice = slice::from_raw_parts(self.header as *const u8, self.header_len);
-            str::from_utf8(slice).unwrap()
+            str::from_utf8(slice).expect("Invalid header string")
         }
     }
 
     pub fn name(&'a self) -> &'a str {
-        self.as_str().split(":").next().unwrap_or("")
+        self.as_str().split(':').next().unwrap_or("").trim()
     }
 
     pub fn value(&'a self) -> Option<&'a str> {
-        self.as_str().split(":").nth(1)
+        self.as_str().split(':').nth(1).map(|s| s.trim())
     }
 }
 

src/zend/linked_list.rs

@@ -33,7 +33,7 @@ impl<'a, T: 'a> Iterator for ZendLinkedListIterator<'a, T> {
         if self.position.is_null() {
             return None;
         }
-        let ptr = unsafe { (&mut *self.position).data.as_mut_ptr() };
+        let ptr = unsafe { (*self.position).data.as_mut_ptr() };
         let value = unsafe { &*(ptr as *const T as *mut T) };
         unsafe {
             zend_llist_get_next_ex(