Revert "Revert "Add integration tests""

Author: danog

Cargo.toml

@@ -41,7 +41,11 @@ closure = []
 embed = []
 
 [workspace]
-members = ["crates/macros", "crates/cli"]
+members = [
+    "crates/macros",
+    "crates/cli",
+    "tests"
+]
 
 [package.metadata.docs.rs]
 rustdoc-args = ["--cfg", "docs"]

guide/src/types/binary.md

@@ -45,7 +45,7 @@ pub fn test_binary(input: Binary<u32>) -> Binary<u32> {
 ```php
 <?php
 
-$data = pack('*L', [1, 2, 3, 4, 5]);
-$output = unpack('*L', test_binary($data));
+$data = pack('L*', 1, 2, 3, 4, 5);
+$output = unpack('L*', test_binary($data));
 var_dump($output); // array(5) { [0] => 5, [1] => 4, [2] => 3, [3] => 2, [4] => 1 }
 ```

src/closure.rs

@@ -171,6 +171,7 @@ class_derives!(Closure);
 ///
 /// This trait is automatically implemented on functions with up to 8
 /// parameters.
+#[allow(clippy::missing_safety_doc)]
 pub unsafe trait PhpClosure {
     /// Invokes the closure.
     fn invoke<'a>(&'a mut self, parser: ArgParser<'a, '_>, ret: &mut Zval);

tests/Cargo.toml

@@ -0,0 +1,12 @@
+[package]
+name = "tests"
+version = "0.0.0"
+edition = "2021"
+publish = false
+license = "MIT OR Apache-2.0"
+
+[dependencies]
+ext-php-rs = { path = "../", features = ["closure"] }
+
+[lib]
+crate-type = ["cdylib"]

tests/src/integration/_utils.php

@@ -0,0 +1,11 @@
+<?php
+
+function assert_exception_thrown(callable $callback): void
+{
+    try {
+        call_user_func($callback);
+    } catch (\Throwable $th) {
+        return;
+    }
+    throw new Exception("Excption was not thrown", 255);
+}

tests/src/integration/array.php

@@ -0,0 +1,26 @@
+<?php
+
+require('_utils.php');
+
+// Tests sequential arrays
+$array = test_array(['a', 'b', 'c']);
+
+assert(is_array($array));
+assert(count($array) === 3);
+assert(in_array('a', $array));
+assert(in_array('b', $array));
+assert(in_array('c', $array));
+
+// Tests associative arrays
+$assoc = test_array_assoc([
+    'a' => '1',
+    'b' => '2',
+    'c' => '3'
+]);
+
+assert(array_key_exists('a', $assoc));
+assert(array_key_exists('b', $assoc));
+assert(array_key_exists('c', $assoc));
+assert(in_array('1', $assoc));
+assert(in_array('2', $assoc));
+assert(in_array('3', $assoc));

tests/src/integration/array.rs

@@ -0,0 +1,4 @@
+#[test]
+fn binary_works() {
+    assert!(crate::integration::run_php("array.php"));
+}

tests/src/integration/binary.php

@@ -0,0 +1,13 @@
+<?php
+
+require('_utils.php');
+
+$bin = test_binary(pack('L*', 1, 2, 3, 4, 5));
+$result = unpack('L*', $bin);
+
+assert(count($result) === 5);
+assert(in_array(1, $result));
+assert(in_array(2, $result));
+assert(in_array(3, $result));
+assert(in_array(4, $result));
+assert(in_array(5, $result));

tests/src/integration/binary.rs

@@ -0,0 +1,4 @@
+#[test]
+fn binary_works() {
+    assert!(crate::integration::run_php("binary.php"));
+}

tests/src/integration/bool.php

@@ -0,0 +1,6 @@
+<?php
+
+require('_utils.php');
+
+assert(test_bool(true) === true);
+assert(test_bool(false) === false);