Skip to content

Commit ee45e8d

Browse files
committed
fix more causes of clippy warnings
Clippy linting had more errors: error: iterating on a map's values Error: --> crates/macros/src/module.rs:56:36 | 56 | let registered_classes_impls = state | ____________________________________^ 57 | | .classes 58 | | .iter() 59 | | .map(|(_, class)| generate_registered_class_impl(class)) | |________________________________________________________________^ | = note: `-D clippy::iter-kv-map` implied by `-D warnings` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map help: try | 56 ~ let registered_classes_impls = state 57 + .classes.values().map(|class| generate_registered_class_impl(class)) | error: iterating on a map's values Error: --> crates/macros/src/module.rs:366:23 | 366 | let classes = self.classes.iter().map(|(_, class)| class.describe()); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.classes.values().map(|class| class.describe())` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map error: could not compile `ext-php-rs-derive` due to 2 previous errors
1 parent 9c5d172 commit ee45e8d

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

crates/macros/src/module.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,8 @@ pub fn parser(input: ItemFn) -> Result<TokenStream> {
5555
});
5656
let registered_classes_impls = state
5757
.classes
58-
.iter()
59-
.map(|(_, class)| generate_registered_class_impl(class))
58+
.values()
59+
.map(generate_registered_class_impl)
6060
.collect::<Result<Vec<_>>>()?;
6161
let describe_fn = generate_stubs(&state);
6262

@@ -363,7 +363,7 @@ impl Describe for crate::constant::Constant {
363363
impl Describe for State {
364364
fn describe(&self) -> TokenStream {
365365
let functs = self.functions.iter().map(Describe::describe);
366-
let classes = self.classes.iter().map(|(_, class)| class.describe());
366+
let classes = self.classes.values().map(|class| class.describe());
367367
let constants = self.constants.iter().map(Describe::describe);
368368

369369
quote! {

0 commit comments

Comments
 (0)