macros: raw identifier bug

[kakserpom]

Branch: master

use ext_php_rs::prelude::*;

#[php_class]
pub struct Example {}
#[php_impl]
impl Example {
    pub fn foo(&self, r#as: &str) {}
}
#[php_module]
pub fn get_module(module: ModuleBuilder) -> ModuleBuilder {
    module.class::<Example>()
}

<?php

// Stubs for untitled5

namespace {
    class Example {
        public function foo(string $r#as) {}

        public function __construct() {}
    }
}

Also, __construct() in stubs is unnecessary since you can't instantiate this class from PHP.

P.S. Pardon me for not using the issue templates :-)

[Xenira]

Sad that this rfc seemed to have gone nowhere https://wiki.php.net/rfc/raw-identifiers

Well, guess ext authors will just have to take care not to use keywords.

[kakserpom]

Well,

➜  ~ php -r 'function($as){};'
➜  ~

So there is no problem with that in PHP. The problem is that the #[php_impl] macro doesn't convert r#as into as.

use ext_php_rs::prelude::*;

#[php_function]
pub fn foo(r#as: &str) {}

#[php_module]
pub fn get_module(module: ModuleBuilder) -> ModuleBuilder {
    module.function(wrap_function!(foo))
}

➜  ~ php -r '?><?=new ReflectionFunction("foo")->getParameters()[0]->getName() . PHP_EOL;'
r#as

[Xenira]

Ye, know that its no problem in php. Just would have been a nice thing to have to just convert raw rust identifiers to raw php identifiers

[kakserpom]

Well, given that PHP variables are prefixed with $, the concept of raw identifiers doesn't really apply to them.

[Xenira]

Sure, but rust raw identifiers can not only used on variable names.

Guess they have the same problem as the one described here.

[kakserpom]

Yeah, so

1. Macro needs to remove the "r#" prefix
2. Check for PHP keywords if necessary and panic accordindly.

This one panics atm, but it shouldn't panic:

use ext_php_rs::prelude::*;

#[php_function]
pub fn r#pub() {}

#[php_module]
pub fn get_module(module: ModuleBuilder) -> ModuleBuilder {
    module.function(wrap_function!(r#pub))
}

This one doesn't panic atm, but it should panic:

use ext_php_rs::prelude::*;

#[php_function]
pub fn endswitch() {}

#[php_module]
pub fn get_module(module: ModuleBuilder) -> ModuleBuilder {
    module.function(wrap_function!(endswitch))
}

It generates a stub file with a syntax error (endswitch is a keyword):

<?php

// Stubs for untitled5

namespace {
    function endswitch() {}
}