Skip to content

Commit e51e23b

Browse files
committed
Fix accessibility for buttons with aria-label
1 parent b0805b8 commit e51e23b

File tree

4 files changed

+10
-8
lines changed

4 files changed

+10
-8
lines changed

src/components/common/searchbar.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ export default function Searchbar(props: { className?: string }) {
3737
/>
3838
<Button
3939
type='submit'
40+
aria-label='search'
4041
className='w-11 h-10 leading-8 align-middle text-center rounded-lg ml-4 cursor-pointer
4142
bg-(--link-color) dark:bg-(--hover-bg-color) hover:bg-(--hover-fg-color)
4243
text-(--main-bg-color) dark:text-(--hover-fg-color) hover:text-white'

src/components/header/toggles/index.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
1-
import DarkmodeToggle from './darkmode-toggle';
2-
import EthNetworkToggle from './eth-network-toggle';
1+
import ThemeToggle from './theme-toggle';
2+
import NetworkPicker from './network-picker';
33

44

55
export default function Toggles() {
66
return (
77
<span className='flex flex-row justify-end min-w-18 mr-3'>
8-
<DarkmodeToggle
8+
<ThemeToggle
99
className='w-6 min-w-6 cursor-pointer hover:text-(--hover-fg-color)'
1010
/>
11-
<EthNetworkToggle
11+
<NetworkPicker
1212
className='w-6 h-6 ml-5 cursor-pointer hover:invert-[0.65]'
1313
/>
1414
</span>

src/components/header/toggles/eth-network-toggle.tsx renamed to src/components/header/toggles/network-picker.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import Link from 'next/link';
66
import { useNetwork } from '@/components/common/network-context';
77

88

9-
export default function EthNetworkToggle(props: { className?: string }) {
9+
export default function NetworkPicker(props: { className?: string }) {
1010
const [ mounted, setMounted ] = useState(false);
1111
const { network } = useNetwork();
1212
const sepolia = network === 'sepolia';
@@ -23,7 +23,8 @@ export default function EthNetworkToggle(props: { className?: string }) {
2323
return (
2424
<Menu>
2525
<MenuButton className={`${props.className}
26-
bg-(image:--eth-logo-url) bg-contain bg-no-repeat bg-right`} />
26+
bg-(image:--eth-logo-url) bg-contain bg-no-repeat bg-right`}
27+
aria-label='Network picker' />
2728
<MenuItems
2829
className='bg-(--main-bg-color)
2930
border-2 border-(--border-color)

src/components/header/toggles/darkmode-toggle.tsx renamed to src/components/header/toggles/theme-toggle.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ type Props = {
99
className?: string
1010
}
1111

12-
export default function DarkmodeToggle(props: Props) {
12+
export default function ThemeToggle(props: Props) {
1313
const { resolvedTheme, setTheme } = useTheme();
1414
const [ mounted, setMounted ] = useState(false);
1515

@@ -45,7 +45,7 @@ export default function DarkmodeToggle(props: Props) {
4545
}
4646

4747
return (
48-
<button className={props.className} onClick={toggleTheme} >
48+
<button className={props.className} onClick={toggleTheme} aria-label='Theme toggle'>
4949
{
5050
resolvedTheme === 'dark' ?
5151
<SunIcon />

0 commit comments

Comments
 (0)