lint the rest of the shell scripts

Author: daviddob

.github/workflows/lint-sh.yaml

@@ -18,5 +18,4 @@ jobs:
       - uses: actions/checkout@v4
       - uses: luizm/action-sh-checker@v0.9.0
         with:
-          sh_checker_exclude: 'scripts/verify-* scripts/update-* scripts/release.sh'
           sh_checker_checkbashisms_enable: true

scripts/release.sh

@@ -3,8 +3,8 @@ set -e
 
 # == would end up with: scripts/release.sh: 5: [: v3.8.1: unexpected operator
 if [ "$1" = "" ]; then
-  echo usage: "$0 VERSION"
-  exit 1
+	echo usage: "$0 VERSION"
+	exit 1
 fi
 
 git tag $1

scripts/update-gofmt.sh

@@ -6,11 +6,11 @@ set -o nounset
 set -o pipefail
 
 find_files() {
-  find . -not \( \
-      \( \
-        -wholename '*/vendor/*' \
-      \) -prune \
-    \) -name '*.go'
+	find . -not \( \
+		\( \
+		-wholename '*/vendor/*' \
+		\) -prune \
+		\) -name '*.go'
 }
 
 find_files | xargs gofmt -w -s

scripts/verify-gofmt.sh

@@ -6,17 +6,17 @@ set -o nounset
 set -o pipefail
 
 find_files() {
-  find . -not \( \
-      \( \
-        -wholename '*/vendor/*' \
-      \) -prune \
-    \) -name '*.go'
+	find . -not \( \
+		\( \
+		-wholename '*/vendor/*' \
+		\) -prune \
+		\) -name '*.go'
 }
 
 bad_files=$(find_files | xargs gofmt -d -s 2>&1)
 if [[ -n "${bad_files}" ]]; then
-  echo "${bad_files}" >&2
-  echo >&2
-  echo "Run ./hack/update-gofmt.sh" >&2
-  exit 1
+	echo "${bad_files}" >&2
+	echo >&2
+	echo "Run ./hack/update-gofmt.sh" >&2
+	exit 1
 fi

scripts/verify-staticcheck.sh

@@ -5,15 +5,15 @@ set -o nounset
 set -o pipefail
 
 find_packages() {
-  find . -not \( \
-      \( \
-        -wholename '*/vendor/*' \
-      \) -prune \
-    \) -name '*.go' -exec dirname '{}' ';' | sort -u
+	find . -not \( \
+		\( \
+		-wholename '*/vendor/*' \
+		\) -prune \
+		\) -name '*.go' -exec dirname '{}' ';' | sort -u
 }
 
 errors="$(find_packages | xargs -I@ bash -c "staticcheck @")"
 if [[ -n "${errors}" ]]; then
-  echo "${errors}"
-  exit 1
+	echo "${errors}"
+	exit 1
 fi