Fix editable fields on NIA page when project is readonly

Co-authored-by: davidfstr <764688+davidfstr@users.noreply.github.com>
Agent-Logs-Url: https://github.com/davidfstr/Crystal-Web-Archiver/sessions/da6ecc28-932b-4524-a6d3-b8aae4d2a83d

Author: Copilot

RELEASE_NOTES.md

@@ -49,6 +49,12 @@ Release Notes ⋮
 * Documentation improvements
     * Project format documented at: <doc/crystalproj_project_format.md>
 
+* Read-only project fixes
+    * Fix editable fields on the "Not in Archive" page to be correctly
+      disabled when the project is opened in read-only mode.
+      The name, URL pattern, source, group name, and download-immediately
+      checkbox were all previously editable even in read-only mode.
+
 * Headless mode fixes
     * UI progress dialogs will now never show in headless mode.
     * wxPython is now never even loaded in headless mode.

src/crystal/server/special_pages.py

@@ -716,29 +716,29 @@ def not_in_archive_html(
             <div id="cr-create-root-url-form" class="cr-create-root-url-form">
                 <div class="cr-form-row">
                     <label class="cr-form-row__label">Name:</label>
-                    <input type="text" id="cr-root-url-name" class="cr-form-row__input" placeholder="e.g. Home">
+                    <input type="text" id="cr-root-url-name" class="cr-form-row__input" placeholder="e.g. Home" {'disabled ' if readonly else ''}>
                 </div>
             </div>
             
             <div id="cr-create-group-form" class="cr-create-group-form" style="display: none;">
                 <div class="cr-form-row">
                     <label class="cr-form-row__label">URL Pattern:</label>
                     <div class="cr-form-input-container">
-                        <input type="text" id="cr-group-url-pattern" class="cr-form-row__input" placeholder="https://example.com/post/*" value="{html_escape(create_group_form_data['predicted_url_pattern'])}">
+                        <input type="text" id="cr-group-url-pattern" class="cr-form-row__input" placeholder="https://example.com/post/*" value="{html_escape(create_group_form_data['predicted_url_pattern'])}" {'disabled ' if readonly else ''}>
                         <div class="cr-form-row__help-text"># = numbers, @ = letters, * = anything but /, ** = anything</div>
                     </div>
                 </div>
                 
                 <div class="cr-form-row">
                     <label class="cr-form-row__label">Source:</label>
-                    <select id="cr-group-source" class="cr-form-row__input">
+                    <select id="cr-group-source" class="cr-form-row__input" {'disabled ' if readonly else ''}>
                         <!-- Source options will be populated by JavaScript -->
                     </select>
                 </div>
                 
                 <div class="cr-form-row">
                     <label class="cr-form-row__label">Name:</label>
-                    <input type="text" id="cr-group-name" class="cr-form-row__input" placeholder="e.g. Post" value="{html_escape(create_group_form_data['predicted_name'])}">
+                    <input type="text" id="cr-group-name" class="cr-form-row__input" placeholder="e.g. Post" value="{html_escape(create_group_form_data['predicted_name'])}" {'disabled ' if readonly else ''}>
                 </div>
                 
                 <div class="cr-form__section">
@@ -752,7 +752,7 @@ def not_in_archive_html(
                 <div class="cr-form__section">
                     <div class="cr-form__section-header">New Group Options</div>
                     <label class="cr-checkbox">
-                        <input type="checkbox" id="cr-download-group-immediately-checkbox" checked onchange="onDownloadImmediatelyCheckboxChange()">
+                        <input type="checkbox" id="cr-download-group-immediately-checkbox" {'disabled ' if readonly else ''}checked onchange="onDownloadImmediatelyCheckboxChange()">
                         <span>Download Group Immediately</span>
                     </label>
                 </div>

src/crystal/tests/test_server.py

@@ -719,6 +719,41 @@ async def test_given_readonly_project_then_all_action_type_radio_buttons_disable
             'Download Only radio button should be disabled in readonly mode'
 
 
+async def test_given_readonly_project_then_all_form_input_fields_disabled() -> None:
+    async with _not_in_archive_page_visible(readonly=True) as server_page:
+        content = server_page.content
+        
+        # Root URL name field should be disabled
+        assert 'id="cr-root-url-name"' in content, \
+            'Root URL name field should be present even in readonly mode'
+        assert 'id="cr-root-url-name" class="cr-form-row__input" placeholder="e.g. Home" disabled' in content, \
+            'Root URL name field should be disabled in readonly mode'
+        
+        # Group URL pattern field should be disabled
+        assert 'id="cr-group-url-pattern"' in content, \
+            'Group URL pattern field should be present even in readonly mode'
+        assert re.search(r'id="cr-group-url-pattern"[^>]+ disabled', content) is not None, \
+            'Group URL pattern field should be disabled in readonly mode'
+        
+        # Group source select should be disabled
+        assert 'id="cr-group-source"' in content, \
+            'Group source select should be present even in readonly mode'
+        assert 'id="cr-group-source" class="cr-form-row__input" disabled' in content, \
+            'Group source select should be disabled in readonly mode'
+        
+        # Group name field should be disabled
+        assert 'id="cr-group-name"' in content, \
+            'Group name field should be present even in readonly mode'
+        assert 'id="cr-group-name" class="cr-form-row__input" placeholder="e.g. Post" value="" disabled' in content, \
+            'Group name field should be disabled in readonly mode'
+        
+        # Download group immediately checkbox should be disabled
+        assert 'id="cr-download-group-immediately-checkbox"' in content, \
+            'Download group immediately checkbox should be present even in readonly mode'
+        assert 'id="cr-download-group-immediately-checkbox" disabled' in content, \
+            'Download group immediately checkbox should be disabled in readonly mode'
+
+
 # - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - 
 # Test: "Not in Archive" Page: Create Root URL + Download Progress Bar