Move requiredSectors() to the base class.

Author: davidgiven

arch/amiga/decoder.cc

@@ -68,12 +68,6 @@ class AmigaDecoder : public Decoder
 		_sector->status = (gotdatachecksum == wanteddatachecksum) ? Sector::OK : Sector::BAD_CHECKSUM;
 	}
 
-	std::set<unsigned> requiredSectors(const Location&) const override
-	{
-		static std::set<unsigned> sectors = { 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 };
-		return sectors;
-	}
-
 private:
 	const AmigaDecoderProto& _config;
 	nanoseconds_t _clock;

arch/apple2/decoder.cc

@@ -144,14 +144,6 @@ class Apple2Decoder : public Decoder
 		_sector->status = Sector::BAD_CHECKSUM;
 		_sector->data = decode_crazy_data(&bytes[0], _sector->status);
 	}
-
-	std::set<unsigned> requiredSectors(const Location& location) const override
-	{
-		std::set<unsigned> sectors;
-		for (int sectorId = 0; sectorId < APPLE2_SECTORS; sectorId++)
-			sectors.insert(sectorId);
-		return sectors;
-	}
 };
 
 std::unique_ptr<Decoder> createApple2Decoder(const DecoderProto& config)

arch/c64/c64.cc

@@ -13,16 +13,6 @@
     * 
     * The clock rate is normalised for a 200ms drive.
     */
-unsigned sectorsForC64Track(unsigned track)
-{
-    if (track < 17)
-        return 21;
-    if (track < 24)
-        return 19;
-    if (track < 30)
-        return 18;
-    return 17;
-}
 
 nanoseconds_t clockPeriodForC64Track(unsigned track)
 {

arch/c64/c64.h

@@ -30,7 +30,6 @@
 extern std::unique_ptr<Decoder> createCommodore64Decoder(const DecoderProto& config);
 extern std::unique_ptr<Encoder> createCommodore64Encoder(const EncoderProto& config);
 
-extern unsigned sectorsForC64Track(unsigned track);
 extern nanoseconds_t clockPeriodForC64Track(unsigned track);
 
 #endif

arch/c64/decoder.cc

@@ -94,15 +94,6 @@ class Commodore64Decoder : public Decoder
         _sector->status =
             (wantChecksum == gotChecksum) ? Sector::OK : Sector::BAD_CHECKSUM;
     }
-
-    std::set<unsigned> requiredSectors(const Location& location) const override
-    {
-        unsigned count = sectorsForC64Track(location.logicalTrack);
-        std::set<unsigned> sectors;
-        for (int sectorId = 0; sectorId < count; sectorId++)
-            sectors.insert(sectorId);
-        return sectors;
-    }
 };
 
 std::unique_ptr<Decoder> createCommodore64Decoder(

arch/ibm/decoder.cc

@@ -207,14 +207,6 @@ class IbmDecoder : public Decoder
             (wantCrc == gotCrc) ? Sector::OK : Sector::BAD_CHECKSUM;
     }
 
-    std::set<unsigned> requiredSectors(const Location& location) const override
-    {
-        auto& trackLayout =
-            Layout::getLayoutOfTrack(location.logicalTrack, location.head);
-        return std::set<unsigned>(trackLayout.logicalSectorOrder.begin(),
-            trackLayout.logicalSectorOrder.end());
-    }
-
 private:
     void getTrackFormat(IbmDecoderProto::TrackdataProto& trackdata,
         unsigned track,

arch/macintosh/decoder.cc

@@ -182,28 +182,6 @@ class MacintoshDecoder : public Decoder
 		_sector->data.clear();
 		_sector->data.writer().append(userData.slice(12, 512)).append(userData.slice(0, 12));
 	}
-
-	std::set<unsigned> requiredSectors(const Location& location) const override
-	{
-		unsigned track = location.logicalTrack;
-
-		int count;
-		if (track < 16)
-			count = 12;
-		else if (track < 32)
-			count = 11;
-		else if (track < 48)
-			count = 10;
-		else if (track < 64)
-			count = 9;
-		else
-			count = 8;
-
-		std::set<unsigned> sectors;
-		while (count--)
-			sectors.insert(count);
-		return sectors;
-	}
 };
 
 std::unique_ptr<Decoder> createMacintoshDecoder(const DecoderProto& config)

arch/micropolis/decoder.cc

@@ -173,12 +173,6 @@ class MicropolisDecoder : public Decoder
 		_sector->status = (wantChecksum == gotChecksum) ? Sector::OK : Sector::BAD_CHECKSUM;
 	}
 
-	std::set<unsigned> requiredSectors(const Location& location) const override
-	{
-		static std::set<unsigned> sectors = { 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15 };
-		return sectors;
-	}
-
 private:
 	const MicropolisDecoderProto& _config;
 	MicropolisDecoderProto_ChecksumType _checksumType;	/* -1 = auto, 1 = Micropolis, 2=MZOS */

arch/northstar/decoder.cc

@@ -164,12 +164,6 @@ class NorthstarDecoder : public Decoder
 		_sector->status = (wantChecksum == gotChecksum) ? Sector::OK : Sector::BAD_CHECKSUM;
 	}
 
-	std::set<unsigned> requiredSectors(const Location&) const override
-	{
-		static std::set<unsigned> sectors = { 0, 1, 2, 3, 4, 5, 6, 7, 8, 9 };
-		return sectors;
-	}
-
 private:
 	const NorthstarDecoderProto& _config;
 	uint8_t _hardSectorId;

lib/decoders/decoders.cc

@@ -225,7 +225,7 @@ uint64_t Decoder::readRaw64()
 
 std::set<unsigned> Decoder::requiredSectors(const Location& location) const
 {
-	static std::set<unsigned> set;
-	return set;
+	const auto& trackLayout = Layout::getLayoutOfTrack(location.logicalTrack, location.head);
+	return std::set(trackLayout.logicalSectorOrder.begin(), trackLayout.logicalSectorOrder.end());
 }