fix: repair svg insertion into Word

see #700

Author: davidgohel

DESCRIPTION

@@ -1,7 +1,7 @@
 Type: Package
 Package: officer
 Title: Manipulation of Microsoft Word and PowerPoint Documents
-Version: 0.7.2.004
+Version: 0.7.2.005
 Authors@R: c(
     person("David", "Gohel", , "david.gohel@ardata.fr", role = c("aut", "cre")),
     person("Stefan", "Moog", , "moogs@gmx.de", role = "aut"),

NEWS.md

@@ -5,6 +5,7 @@
 - RTF support strike text setting.
 - fix an issue with bookmark selections in `docx_summary()`.
 - fix `fp_par_lite()` management of argument `tabs`.
+- there was a regression with svg in docx, it is solved now.
 
 ## Features
 

R/post-proc.R

@@ -213,13 +213,13 @@ sanitize_images <- function(x, warn_user = TRUE) {
     all_docs[[length(all_docs)+1]] <- x$doc_obj
     all_docs[[length(all_docs)+1]] <- x$footnotes
 
-    for (header in all_docs) {
+    for (doc_part in all_docs) {
       suppressWarnings({
-        blip_nodes <- xml_find_all(header$get(), "//a:blip[contains(@r:embed, 'rId')]")
+        blip_nodes <- xml_find_all(doc_part$get(), "//a:blip[contains(@r:embed, 'rId')]|//asvg:svgBlip[contains(@r:embed, 'rId')]")
       })
       embed_list <- xml_attr(blip_nodes, "embed")
       embed_data <- filter(
-        .data = header$rel_df(),
+        .data = doc_part$rel_df(),
         basename(.data$type) %in% "image",
         .data$id %in% embed_list
       )

tests/testthat/test-images.R

@@ -139,6 +139,10 @@ test_that("add svg in docx", {
     expect_false(inherits(node_svgblip, "xml_missing"))
     expect_true(all(xml_attr(node_svgblip, "embed") %in% subset_rel$id))
   }
+  new_file <- print(x, target = tempfile(fileext = ".docx"))
+  new_folder <- unpack_folder(new_file, tempfile())
+  media_files <- list.files(file.path(new_folder, "word", "media"))
+  expect_length(media_files, 2)
 })
 
 test_that("add svg in pptx", {