Remove all alarm/timer classes. Renaming with anel plugin works now again without activity crash. Remove donations library.

Author: David Graeff

app/app.iml

@@ -114,6 +114,5 @@
     <orderEntry type="library" exported="" scope="TEST" name="junit-4.11" level="project" />
     <orderEntry type="library" exported="" name="ndeftools-util-1.2.4" level="project" />
     <orderEntry type="library" exported="" name="cardview-v7-22.0.0" level="project" />
-    <orderEntry type="module" module-name="Donations" exported="" />
   </component>
 </module>

app/build.gradle

@@ -92,7 +92,6 @@ android {
 dependencies {
     //compile fileTree(dir: 'libs', include: ['*.jar']) :5.2.08 5.0.89
     //compile 'com.google.android.gms:play-services:5.2.08'
-    compile project(':libraries:Donations')
     //noinspection GradleDependency
     compile 'com.android.support:appcompat-v7:22.0.0'
     compile 'com.android.support:support-v13:22.0.0'

app/src/main/java/oly/netpowerctrl/data/AbstractBasePlugin.java

@@ -98,4 +98,6 @@ public boolean isNewIOConnectionAllowed(Credentials credentials) {
      */
     public void addNewIOConnection(@NonNull Credentials credentials, @NonNull onNewIOConnection callback) {
     }
+
+    public abstract boolean supportsRemoteRename();
 }

app/src/main/java/oly/netpowerctrl/data/DataService.java

@@ -31,11 +31,11 @@
 import oly.netpowerctrl.main.GuiThreadHandler;
 import oly.netpowerctrl.main.MainActivity;
 import oly.netpowerctrl.network.NetworkChangedBroadcastReceiver;
+import oly.netpowerctrl.network.ReachabilityStates;
+import oly.netpowerctrl.network.UDPSend;
 import oly.netpowerctrl.plugin_anel.AnelPlugin;
 import oly.netpowerctrl.plugin_simpleudp.SimpleUDPPlugin;
-import oly.netpowerctrl.preferences.SharedPrefs;
 import oly.netpowerctrl.status_bar.FavCollection;
-import oly.netpowerctrl.timer.TimerCollection;
 import oly.netpowerctrl.utils.Logging;
 
 /**
@@ -59,7 +59,6 @@ public class DataService extends Service implements onDataLoaded, onDataQueryCom
     final public CredentialsCollection credentials = new CredentialsCollection(this);
     final public GroupCollection groups = new GroupCollection(this);
     final public FavCollection favourites = new FavCollection(this);
-    final public TimerCollection timers = new TimerCollection(this);
     final public IOConnectionsCollection connections = new IOConnectionsCollection(this);
     private final DataLoadedObserver observersOnDataLoaded = new DataLoadedObserver();
     private final List<AbstractBasePlugin> plugins = new ArrayList<>();
@@ -173,9 +172,6 @@ public int onStartCommand(@Nullable final Intent intent, final int flags, final
             return START_NOT_STICKY;
         } else {
             Logging.getInstance().logMain("START");
-            // Although the next alarm should be registered to android already,
-            // we do it again, just to be sure.
-            TimerCollection.armAndroidAlarm(this, SharedPrefs.getNextAlarmCheckTimestamp(this));
         }
 
         // We are a singleton, set the instance variable now.
@@ -233,6 +229,8 @@ public void onDestroy() {
         loadStoreCollections.finish(this);
         loadStoreCollections = null;
 
+        UDPSend.killSendThread();
+
         // Clean up
         for (AbstractBasePlugin abstractBasePlugin : plugins)
             abstractBasePlugin.onDestroy();
@@ -332,7 +330,6 @@ public void clear() {
         connections.storage.clear();
         credentials.storage.clear();
         groups.storage.clear();
-        timers.storage.clear();
         executables.storage.clear();
         observersOnDataLoaded.reset();
     }
@@ -406,6 +403,14 @@ public void onObserverJobFinished(DevicesObserver devicesObserver) {
         }
     }
 
+    /**
+     * This is issued by the network observer if no network connection is active (no wlan, no mobile network)
+     */
+    public void makeAllOffline() {
+        connections.clearNotConfigured();
+        connections.applyStateToAll(ReachabilityStates.NotReachable);
+    }
+
     public void remove(Credentials credentials) {
         this.executables.remove(credentials);
         this.connections.remove(credentials);

app/src/main/java/oly/netpowerctrl/data/LoadStoreCollections.java

@@ -17,7 +17,6 @@
 import oly.netpowerctrl.main.App;
 import oly.netpowerctrl.preferences.SharedPrefs;
 import oly.netpowerctrl.status_bar.FavItem;
-import oly.netpowerctrl.timer.Timer;
 import oly.netpowerctrl.ui.notifications.InAppNotifications;
 import oly.netpowerctrl.utils.FactoryInterface;
 import oly.netpowerctrl.utils.IOInterface;
@@ -80,7 +79,6 @@ public void loadData(final DataService dataService) {
         dataService.connections.getStorage().setStorage(this);
         dataService.executables.getStorage().setStorage(this);
         dataService.groups.getStorage().setStorage(this);
-        dataService.timers.getStorage().setStorage(this);
         dataService.favourites.getStorage().setStorage(this);
 
         new AsyncTask<Void, Void, Boolean>() {
@@ -111,7 +109,6 @@ public void finish(DataService dataService) {
         dataService.connections.getStorage().setStorage(null);
         dataService.executables.getStorage().setStorage(null);
         dataService.groups.getStorage().setStorage(null);
-        dataService.timers.getStorage().setStorage(null);
         dataService.favourites.getStorage().setStorage(null);
     }
 
@@ -223,12 +220,6 @@ private void readOtherThread(final DataService dataService) {
             e.printStackTrace();
         }
 
-        try {
-            readOtherThreadCollection(dataService.timers.getStorage(), Timer.class, false);
-        } catch (Exception e) {
-            e.printStackTrace();
-        }
-
         try {
             readOtherThreadCollection(dataService.favourites.getStorage(), FavItem.class, false);
         } catch (Exception e) {

app/src/main/java/oly/netpowerctrl/data/importexport/ImportExport.java

@@ -35,7 +35,6 @@ public static void clearData(DataService dataService) {
         loadStoreCollections.clear(dataService.connections.getStorage());
         loadStoreCollections.clear(dataService.executables.getStorage());
         loadStoreCollections.clear(dataService.credentials.getStorage());
-        loadStoreCollections.clear(dataService.timers.getStorage());
     }
 
     @SuppressWarnings("ResultOfMethodCallIgnored")

app/src/main/java/oly/netpowerctrl/executables/Executable.java

@@ -138,12 +138,11 @@ public int getCurrentValueToggled() {
     public void setTitle(String title, @NonNull onNameChangeResult callback) {
         if (title.equals(this.title)) return;
 
-        this.title = title;
-
-        if (credentials != null) {
+        if (credentials != null && credentials.getPlugin().supportsRemoteRename()) {
             callback.onNameChangeStart(this);
             credentials.getPlugin().setTitle(this, title, callback);
-        }
+        } else
+            this.title = title;
     }
 
     public boolean isHidden() {

app/src/main/java/oly/netpowerctrl/executables/ExecutablesFragment.java

@@ -299,7 +299,7 @@ public void onClick(View view) {
             @Override
             public void onClick(View view) {
                 if (SharedPrefs.getInstance().isFirstTimeSceneAdd()) {
-                    SceneHelp.showHelp(getActivity());
+                    SceneHelp.showHelp(getActivity(), R.string.scene_add, R.string.help_scene);
                 } else {
                     Intent it = new Intent(getActivity(), EditActivity.class);
                     it.putExtra(EditActivity.CREATE_SCENE, true);

app/src/main/java/oly/netpowerctrl/ioconnection/IOConnectionsCollection.java

@@ -280,4 +280,15 @@ public Set<Integer> getAllUDPReceivePorts(AbstractBasePlugin plugin) {
         }
         return ports;
     }
+
+    public void applyStateToAll(ReachabilityStates state) {
+        for (DeviceIOConnections deviceIOConnections : items.values()) {
+            for (Iterator<IOConnection> iterator = deviceIOConnections.iterator(); iterator.hasNext(); ) {
+                IOConnection ioConnection = iterator.next();
+                ioConnection.resetChanged();
+                ioConnection.setReachability(state);
+                putInternal(deviceIOConnections, ioConnection);
+            }
+        }
+    }
 }

app/src/main/java/oly/netpowerctrl/main/App.java

@@ -83,6 +83,7 @@ public void onCreate() {
             config.setFormUriBasicAuthPassword(getString(R.string.acralyzer_http_pwd));
             config.setReportType(HttpSender.Type.JSON);
             config.setResToastText(R.string.crash_toast_text);
+            config.setBuildConfigClass(BuildConfig.class);
             try {
                 config.setMode(ReportingInteractionMode.TOAST);
             } catch (ACRAConfigurationException e) {