Skip to content

Commit 50f7055

Browse files
sburnsdavidguttman
authored andcommitted
Add prop to control sub dimension option (#71)
1 parent 4859de6 commit 50f7055

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

index.jsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,8 @@ module.exports = createReactClass({
3636
compact: false,
3737
excludeSummaryFromExport: false,
3838
onData: function () {},
39-
soloText: "solo"
39+
soloText: "solo",
40+
subDimensionText: "Sub Dimension..."
4041
}
4142
},
4243

@@ -123,6 +124,7 @@ module.exports = createReactClass({
123124
{ this.props.hideDimensionFilter ? '' :
124125
<Dimensions
125126
dimensions={this.props.dimensions}
127+
subDimensionText={this.props.subDimensionText}
126128
selectedDimensions={this.state.dimensions}
127129
onChange={this.setDimensions} />
128130
}

lib/dimensions.jsx

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,14 @@ module.exports = createReactClass({
88
return {
99
dimensions: [],
1010
selectedDimensions: [],
11-
onChange: function () {}
11+
onChange: function () { },
12+
subDimensionText: "Sub Dimension..."
1213
}
1314
},
1415

1516
render: function () {
1617
var self = this
18+
var subDimensionText = this.props.subDimensionText
1719
var selectedDimensions = this.props.selectedDimensions
1820
var nSelected = selectedDimensions.length
1921

@@ -22,8 +24,8 @@ module.exports = createReactClass({
2224
{selectedDimensions.map(this.renderDimension)}
2325

2426
<select value={''} onChange={partial(self.toggleDimension, nSelected)}>
25-
<option value={''}>Sub Dimension...</option>
26-
{self.props.dimensions.map(function(dimension) {
27+
<option value={''}>{subDimensionText}</option>
28+
{self.props.dimensions.map(function (dimension) {
2729
return <option key={dimension.title}>{dimension.title}</option>
2830
})}
2931
</select>

0 commit comments

Comments
 (0)