Pytest fixtures inside classes

[jakubbortlik]

Hi and thanks for the amazing software!

I'm using Jedi through python-lsp-server inside Neovim - this chain of tools makes me doubt whether this is the right place to ask about this, but hopefully it is.

And I'd like to ask about the possibility of supporting the resolution of Pytest fixtures when a fixture is defined inside a class.

The following example show the current behaviour where a fixture (fix) defined as a method inside a class is not recognized properly and the fix parameter in test_fix is incorrectly linked by Jedi to the function defined outside the class while Pytest will actually use the class method.

Would it be possible to fix this? Thanks!

import pytest


class Obj:
    attr = 1


class OtherObj:
    other_attr = 1


@pytest.fixture
def fix():
    return Obj()


class TestClass:
    @pytest.fixture
    def fix(self):
        return OtherObj()

    def test_fix(self, fix):
        fix.attr  # gets completed but should not, goToDefinition takes me to the function but should take me to the method
        fix.other_attr  # doesn't get completed but should

[davidhalter]

It feels like it should be possible to fix this, but unless you do it yourself, it's probably unlikely to happen. I would personally rather add pytest support to Zuban than doing some small bug fixes here. I just don't have that much time. But I'm happy to review patches.

[jakubbortlik]

Hi David, thanks for your response. Zuban sounds like an awesome project (rust btw!), I've just measured it on one of our codebases where it tested the repo in 0.6 seconds as opposed to Mypy's 10 seconds - that's impressive. But Zuban also found 290 errors while Mypy didn't find any, so for me it seems it's not just a simple replacement, but I'll definitely keep an eye on Zuban!

I'd like to try and implement the behaviour that I'm asking about in this issue. I see there are instructions on how the tests work in test/run.py so I'll just read through it and try to come up with some PR.

[davidhalter]

But Zuban also found 290 errors while Mypy didn't find any, so for me it seems it's not just a simple replacement

I can offer commercial support and fix those issues, but I understand if this is not what you want.