Skip to content

Commit cf18bac

Browse files
chore(go/adbc): Bump github.com/snowflakedb/gosnowflake from 1.17.0 to 1.17.1 in /go/adbc (apache#3698)
Bumps [github.com/snowflakedb/gosnowflake](https://github.com/snowflakedb/gosnowflake) from 1.17.0 to 1.17.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/snowflakedb/gosnowflake/releases">github.com/snowflakedb/gosnowflake's releases</a>.</em></p> <blockquote> <h2>Release</h2> <ul> <li>Please check Snowflake <a href="https://docs.snowflake.com/en/release-notes/clients-drivers/golang">Go Snowflake for release notes</a>.</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/snowflakedb/gosnowflake/blob/master/CHANGELOG.md">github.com/snowflakedb/gosnowflake's changelog</a>.</em></p> <blockquote> <h2>1.17.1</h2> <ul> <li><code>snowflakedb/gosnowflake#1604</code></li> <li><code>snowflakedb/gosnowflake#1577</code></li> <li><code>snowflakedb/gosnowflake#1556</code></li> <li>Exposed <code>QueryStatus</code> from <code>SnowflakeResult</code> and <code>SnowflakeRows</code> in <code>GetStatus()</code><code>snowflakedb/gosnowflake#1556</code></li> <li><code>snowflakedb/gosnowflake#1531</code></li> <li><code>snowflakedb/gosnowflake#1574</code></li> <li><code>snowflakedb/gosnowflake#1588</code></li> <li>Added <code>CrlDownloadMaxSize</code><code>snowflakedb/gosnowflake#1588</code></li> <li>Added platform telemetry to login requests. Can be disabled with <code>SNOWFLAKE_DISABLE_PLATFORM_DETECTION</code><code>snowflakedb/gosnowflake#1601</code></li> <li><code>snowflakedb/gosnowflake#1593</code></li> <li><code>snowflakedb/gosnowflake#1584</code></li> <li><code>snowflakedb/gosnowflake#1592</code></li> <li><code>snowflakedb/gosnowflake#1595</code></li> <li><code>snowflakedb/gosnowflake#1597</code></li> <li><code>snowflakedb/gosnowflake#1570</code></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/snowflakedb/gosnowflake/commit/8853b49f7a41c3f4775995430110ad96bd672984"><code>8853b49</code></a> SNOW-2371587 Bumped up GoLang connector PATCH version from 1.17.0 to 1.17.1 (...</li> <li><a href="https://github.com/snowflakedb/gosnowflake/commit/190458105c3190f9958cd749e0821316366349bf"><code>1904581</code></a> Release memory earlier (<a href="https://redirect.github.com/snowflakedb/gosnowflake/issues/1598">#1598</a>)</li> <li><a href="https://github.com/snowflakedb/gosnowflake/commit/31eacf2bc9a4489b4d4eb0d6a6eb291b51acd647"><code>31eacf2</code></a> SNOW-2236558 Fix platform detection env check (<a href="https://redirect.github.com/snowflakedb/gosnowflake/issues/1608">#1608</a>)</li> <li><a href="https://github.com/snowflakedb/gosnowflake/commit/147a34fccbf6c02a62dfcd2a4bcd6de9b91c79ad"><code>147a34f</code></a> SNOW-2236558 platform detection (<a href="https://redirect.github.com/snowflakedb/gosnowflake/issues/1601">#1601</a>)</li> <li><a href="https://github.com/snowflakedb/gosnowflake/commit/fda861cc25b53fd676714dfbeeeaece4be0b9652"><code>fda861c</code></a> SNOW-2298165 Fix wrong context being used in updateFileMetadataWithPresignedU...</li> <li><a href="https://github.com/snowflakedb/gosnowflake/commit/ca42b3c17865d49391e81e6971c7db26b134d0a2"><code>ca42b3c</code></a> NO-SNOW: Changelog update of enabling testing for RHEL9 (<a href="https://redirect.github.com/snowflakedb/gosnowflake/issues/1606">#1606</a>)</li> <li><a href="https://github.com/snowflakedb/gosnowflake/commit/e88ca6f89a8e9d9e1a7f392c187fac98b40013e9"><code>e88ca6f</code></a> Fix Panic on supportedDecfloatBind when a nil pointer is passed (<a href="https://redirect.github.com/snowflakedb/gosnowflake/issues/1604">#1604</a>)</li> <li><a href="https://github.com/snowflakedb/gosnowflake/commit/107e39b4d617d0d9e80642fae7c04d6b3055359b"><code>107e39b</code></a> SNOW-1017604: logging improvements (<a href="https://redirect.github.com/snowflakedb/gosnowflake/issues/1570">#1570</a>)</li> <li><a href="https://github.com/snowflakedb/gosnowflake/commit/b5030199c629c9f39956f2d2bea0e8114d8b8c83"><code>b503019</code></a> SNOW-2208212: RHEL support in Go (<a href="https://redirect.github.com/snowflakedb/gosnowflake/issues/1597">#1597</a>)</li> <li><a href="https://github.com/snowflakedb/gosnowflake/commit/8c48f5dde79d844a62d71f94c7387d8fec71e685"><code>8c48f5d</code></a> SNOW-1553756 split secure store manager into keyring and non-keyring parts (...</li> <li>Additional commits viewable in <a href="https://github.com/snowflakedb/gosnowflake/compare/v1.17.0...v1.17.1">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/snowflakedb/gosnowflake&package-manager=go_modules&previous-version=1.17.0&new-version=1.17.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Matt Topol <zotthewizard@gmail.com>
1 parent 9a1df76 commit cf18bac

File tree

6 files changed

+11
-22
lines changed

6 files changed

+11
-22
lines changed

.github/workflows/native-unix.yml

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -424,19 +424,11 @@ jobs:
424424
run: |
425425
sudo sysctl vm.mmap_rnd_bits=28
426426
427-
- name: Install staticcheck
428-
run: go install honnef.co/go/tools/cmd/staticcheck@latest
429427
- name: Go Build
430428
run: |
431429
./ci/scripts/go_build.sh "$(pwd)" "$(pwd)/build" "$HOME/local"
432-
- name: Run Staticcheck
433-
run: |
434-
pushd go/adbc
435-
staticcheck -f stylish ./...
436-
popd
437430
- name: Go Test
438431
env:
439-
SNOWFLAKE_DATABASE: ARROW_OSS_DB
440432
SNOWFLAKE_URI: ${{ secrets.SNOWFLAKE_URI }}
441433
run: |
442434
./ci/scripts/go_test.sh "$(pwd)" "$(pwd)/build" "$HOME/local"
@@ -502,9 +494,6 @@ jobs:
502494
check-latest: true
503495
cache: true
504496
cache-dependency-path: go/adbc/go.sum
505-
- name: Install staticcheck
506-
if: matrix.os == 'ubuntu-latest'
507-
run: go install honnef.co/go/tools/cmd/staticcheck@latest
508497

509498
- uses: actions/download-artifact@v6
510499
with:
@@ -520,12 +509,7 @@ jobs:
520509
run: |
521510
export PATH=$RUNNER_TOOL_CACHE/go/${GO_VERSION}/${{ matrix.goarch }}/bin:$PATH
522511
./ci/scripts/go_build.sh "$(pwd)" "$(pwd)/build" "$HOME/local"
523-
- name: Run Staticcheck
524-
if: matrix.os == 'ubuntu-latest'
525-
run: |
526-
pushd go/adbc
527-
staticcheck -f stylish ./...
528-
popd
512+
529513
- name: Go Test
530514
env:
531515
SNOWFLAKE_URI: ${{ secrets.SNOWFLAKE_URI }}

c/driver/postgresql/meson.build

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ adbc_postgres_driver_lib = library(
2828
'result_reader.cc',
2929
'statement.cc',
3030
],
31-
include_directories: [include_dir, c_dir],
31+
include_directories: [include_dir, c_dir, safe_math_dir],
3232
link_with: [adbc_common_lib, adbc_framework_lib],
3333
dependencies: [nanoarrow_dep, fmt_dep, libpq_dep],
3434
)
@@ -64,7 +64,7 @@ foreach name, conf : postgres_tests
6464
exc = executable(
6565
'adbc-' + name + '-test',
6666
sources: conf['sources'],
67-
include_directories: [include_dir, driver_dir, c_dir],
67+
include_directories: [include_dir, driver_dir, c_dir, safe_math_dir],
6868
link_with: [adbc_common_lib, adbc_postgres_driver_lib],
6969
dependencies: [libpq_dep, adbc_validation_dep],
7070
)

c/meson.build

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ install_headers('include/arrow-adbc/adbc.h', subdir: 'arrow-adbc')
4545
driver_dir = include_directories('driver')
4646
nanoarrow_dep = dependency('nanoarrow')
4747
fmt_dep = dependency('fmt')
48+
safe_math_dir = include_directories('vendor/portable-snippets/include')
4849

4950
if get_option('tests').enabled()
5051
gtest_main_dep = dependency('gtest_main')

go/adbc/driver/snowflake/snowflake_database.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,7 @@ type databaseImpl struct {
8282
defaultAppName string
8383
}
8484

85+
//nolint:staticcheck // ignore snowflake deprecated warnings for now
8586
func (d *databaseImpl) GetOption(key string) (string, error) {
8687
switch key {
8788
case adbc.OptionKeyUsername:
@@ -199,6 +200,7 @@ func (d *databaseImpl) SetOptions(cnOptions map[string]string) error {
199200
}
200201
// XXX(https://github.com/apache/arrow-adbc/issues/2792): Snowflake
201202
// has a tendency to spam the log by default, so set the log level
203+
//nolint:staticcheck // ignore snowflake deprecated warnings for now
202204
d.cfg.Tracing = "fatal"
203205

204206
// set default application name to track
@@ -218,6 +220,8 @@ func (d *databaseImpl) SetOptions(cnOptions map[string]string) error {
218220
// SetOptionInternal sets the option for the database.
219221
//
220222
// cnOptions is nil if the option is being set post-initialiation.
223+
//
224+
//nolint:staticcheck // ignore snowflake deprecated warnings for now
221225
func (d *databaseImpl) SetOptionInternal(k string, v string, cnOptions *map[string]string) error {
222226
var err error
223227
var ok bool

go/adbc/go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ require (
2828
github.com/databricks/databricks-sql-go v1.9.0
2929
github.com/golang/protobuf v1.5.4
3030
github.com/google/uuid v1.6.0
31-
github.com/snowflakedb/gosnowflake v1.17.0
31+
github.com/snowflakedb/gosnowflake v1.17.1
3232
github.com/stretchr/testify v1.11.1
3333
github.com/youmark/pkcs8 v0.0.0-20201027041543-1326539a0a0a
3434
go.opentelemetry.io/otel v1.38.0

go/adbc/go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -243,8 +243,8 @@ github.com/rs/zerolog v1.28.0 h1:MirSo27VyNi7RJYP3078AA1+Cyzd2GB66qy3aUHvsWY=
243243
github.com/rs/zerolog v1.28.0/go.mod h1:NILgTygv/Uej1ra5XxGf82ZFSLk58MFGAUS2o6usyD0=
244244
github.com/sirupsen/logrus v1.9.3 h1:dueUQJ1C2q9oE3F7wvmSGAaVtTmUizReu6fjN8uqzbQ=
245245
github.com/sirupsen/logrus v1.9.3/go.mod h1:naHLuLoDiP4jHNo9R0sCBMtWGeIprob74mVsIT4qYEQ=
246-
github.com/snowflakedb/gosnowflake v1.17.0 h1:be50vC0buiOitvneyRHiqNkvPMcunGD3EcTnL2zYATg=
247-
github.com/snowflakedb/gosnowflake v1.17.0/go.mod h1:TaHvQGh9MA2lopZZMm1AvvENDfwcnKtuskIr1e6Fpic=
246+
github.com/snowflakedb/gosnowflake v1.17.1 h1:sBYExPDRv6hHF7fCqeXMT745L326Byw/cROxvCiEJzo=
247+
github.com/snowflakedb/gosnowflake v1.17.1/go.mod h1:TaHvQGh9MA2lopZZMm1AvvENDfwcnKtuskIr1e6Fpic=
248248
github.com/spf13/pflag v1.0.3/go.mod h1:DYY7MBk1bdzusC3SYhjObp+wFpr4gzcvqqNjLnInEg4=
249249
github.com/spiffe/go-spiffe/v2 v2.5.0 h1:N2I01KCUkv1FAjZXJMwh95KK1ZIQLYbPfhaxw8WS0hE=
250250
github.com/spiffe/go-spiffe/v2 v2.5.0/go.mod h1:P+NxobPc6wXhVtINNtFjNWGBTreew1GBUCwT2wPmb7g=

0 commit comments

Comments
 (0)