Fix DictView and broken account access on remote

Author: davidhozic

docs/source/changelog.rst

@@ -32,6 +32,11 @@ Glossary
 Releases
 ----------------------
 
+v2.8.5
+=================
+- Fixed "Object not added to DAF" when accessing broken accounts from remote
+
+
 v2.8.4
 =================
 - Fixed web browser waiting time being too little when searching invite links

src/daf/core.py

@@ -142,7 +142,7 @@ async def schema_load_from_file() -> None:
 
     trace("Restoring objects from file...", TraceLEVELS.NORMAL)
     with open(SHILL_LIST_BACKUP_PATH, "rb") as reader:
-        accounts = convert.convert_from_semi_dict(pickle.load(reader))
+        accounts: List[client.ACCOUNT] = convert.convert_from_semi_dict(pickle.load(reader))
 
     trace("Updating accounts.", TraceLEVELS.DEBUG)
     for account in accounts:
@@ -156,6 +156,8 @@ async def schema_load_from_file() -> None:
                 TraceLEVELS.ERROR, exc
             )
         finally:
+            # Save ID regardless if we failed result otherwise we cannot access though remote
+            account._update_tracked_id()
             GLOBALS.accounts.append(account)
 
     trace(f"Restored objects from file ({len(GLOBALS.accounts)} accounts).", TraceLEVELS.NORMAL)

src/daf/misc.py

@@ -261,12 +261,15 @@ class TrackedClass(cls):
         if hasattr(cls, "__slots__"):  # Don't break classes without slots
             __slots__ = ("__weakref__", "_daf_id")
 
-        async def initialize(self, *args, **kwargs):
-            _r = await super().initialize(*args, **kwargs)
-            # Update weakref dictionary
+        def _update_tracked_id(self):
+            "Saves ID to the tracked dictionary"
             value = id(self)
             self._daf_id = value
             OBJECT_ID_MAP[value] = self
+
+        async def initialize(self, *args, **kwargs):
+            _r = await super().initialize(*args, **kwargs)
+            self._update_tracked_id()
             return _r
 
         def __getattr__(self, __key: str):