Feat/fix bugs (#400)

* Fix bugs

* bug fixes

Author: davidhozic

docs/source/changelog.rst

@@ -32,6 +32,13 @@ Glossary
 Releases
 ----------------------
 
+v2.9.6
+=================
+- Fixed crash if ``start_period`` is larger than ``end_period``.
+- Fixed local update not showing errors if updating objects under AutoGUILD
+
+
+
 v2.9.5
 =================
 - Fixed incorrect caching of the SQL logs, causing incorrect values to be returned back to the GUI.

src/daf/__init__.py

@@ -19,4 +19,4 @@
     from .misc import *
 
 
-VERSION = "2.9.5"
+VERSION = "2.9.6"

src/daf/client.py

@@ -490,15 +490,13 @@ async def update(self, **kwargs):
             if isinstance(intents, discord.Intents) and intents.value == 0:
                 kwargs["intents"] = None
 
-        servers = kwargs.pop("servers", self.servers + self._uiservers)
-        if servers is None:
-            servers = []
+        kwargs["servers"] = kwargs.pop("servers", self.servers + self._uiservers)
 
         @misc._async_safe("_update_sem")
         async def update_servers(self_):
             _servers = []
             _autoguilds = []
-            for server in servers:
+            for server in self.servers:
                 try:
                     await server.update(init_options={"parent": self})
                     if isinstance(server, guild._BaseGUILD):
@@ -516,6 +514,5 @@ async def update_servers(self_):
             await update_servers(self)
         except Exception:
             await self.initialize()  # re-login
-            servers = self.servers  # Only return initialized servers
             await update_servers(self)
             raise

src/daf/message/base.py

@@ -142,6 +142,9 @@ def __init__(self,
             trace("Using int on end_period is deprecated, use timedelta object instead.", TraceLEVELS.DEPRECATED)
             end_period = timedelta(seconds=end_period)
 
+        if isinstance(start_period, timedelta) and start_period >= end_period:
+            raise ValueError("'start_period' must be less than 'end_period'")
+
         # Clamp periods to minimum level (prevent infinite loops)
         self.start_period = None if start_period is None else max(start_period, timedelta(seconds=C_PERIOD_MINIMUM_SEC))
         self.end_period = max(end_period, timedelta(seconds=C_PERIOD_MINIMUM_SEC))
@@ -546,6 +549,9 @@ async def update(self, init_options = None, **kwargs):
         Any
             Raised from :py:meth:`~daf.message.AutoCHANNEL.initialize` method.
         """
+        if self.parent is None:
+            raise ValueError(f"{type(self).__name__} is not initialized. If this is under AutoGUILD, update AutoGUILD instead.")
+
         if init_options is None:
             init_options = {}
             init_options["parent"] = self.parent

src/daf/message/text_based.py

@@ -548,6 +548,9 @@ async def update(self, _init_options: Optional[dict] = None, **kwargs: Any):
         Other
             Raised from .initialize() method.
         """
+        if self.parent is None:
+            raise ValueError(f"{type(self).__name__} is not initialized. If this is under AutoGUILD, update AutoGUILD instead.")
+
         if "start_in" not in kwargs:
             # This parameter does not appear as attribute, manual setting necessary
             kwargs["start_in"] = self.next_send_time

src/daf/message/voice_based.py

@@ -410,6 +410,9 @@ async def update(self, _init_options: Optional[dict] = None, **kwargs):
         Other
             Raised from .initialize() method
         """
+        if self.parent is None:
+            raise ValueError(f"{type(self).__name__} is not initialized. If this is under AutoGUILD, update AutoGUILD instead.")
+
         if "start_in" not in kwargs:
             # This parameter does not appear as attribute, manual setting necessary
             kwargs["start_in"] = self.next_send_time