Ensuring input controls maintain their type attributes. Fixes #554

Author: davidkpiano

src/components/control-component.js

@@ -636,6 +636,7 @@ function createControlClass(customControlPropsMap = {}, s = defaultStrategy) {
       component="input"
       mapProps={{
         ...controlPropsMap.text,
+        type: 'text',
         ...props.mapProps,
       }}
       {...omit(props, 'mapProps')}

src/constants/control-props-map.js

@@ -59,10 +59,7 @@ function createControlPropsMap() {
       ...standardPropsMap,
       value: (props) => (props.modelValue),
     },
-    text: {
-      ...textPropsMap,
-      type: 'text',
-    },
+    text: textPropsMap,
     textarea: textPropsMap,
     file: standardPropsMap,
     button: standardPropsMap,

test/control-component-spec.js

@@ -217,6 +217,10 @@ Object.keys(testContexts).forEach((testKey) => {
           it('should have a type="text"', () => {
             assert.equal(node.getAttribute('type'), 'text');
           });
+        } else {
+          it('should have the appropriate type attribute', () => {
+            assert.equal(node.getAttribute('type'), type);
+          });
         }
       });
     });

test/field-component-spec.js

@@ -291,6 +291,10 @@ Object.keys(testContexts).forEach((testKey) => {
             get(store.getState().test, 'foo'),
             'testing again');
         });
+
+        it('should have the appropriate type attribute', () => {
+          assert.equal(node.getAttribute('type'), type);
+        });
       });
 
       describe(`with a controlled <${element} ${type ? `type="${type}"` : ''} /> component`, () => {