Ensuring that result from actions.remove retains field state as object. Fixes #553

Author: davidkpiano

docs/api/Control.md

@@ -14,6 +14,7 @@
 - [`controlProps`](#prop-controlProps)
 - [`component`](#prop-component)
 - [`ignore`](#prop-ignore)
+- [`disabled`](#disabled)
 
 ## `<Control>`
 

examples/quick-start/components/user-form.js

@@ -1,6 +1,9 @@
 import React from 'react';
 import { LocalForm, Form, actions, Control, Field, Errors } from 'react-redux-form';
 import { connect } from 'react-redux';
+import icepick from 'icepick';
+
+window.i = icepick;
 
 const required = (val) => !!(val && val.length);
 

src/reducers/form/change-action-reducer.js

@@ -51,7 +51,7 @@ function updateFieldValue(field, action, parentModel = undefined) {
         result[key] = field[key];
       });
 
-      return i.set(compact(result), '$form', field.$form);
+      return { ...i.set(compact(result), '$form', field.$form) };
     }
 
     result = { ...field };

test/actions-spec.js

@@ -244,6 +244,52 @@ describe('model action creators', () => {
 
       fn(dispatch, getState);
     });
+
+    it('should remove from collections of complex values', (done) => {
+      const getState = () => ({
+        foo: {
+          bar: [
+            { value: 1 },
+            { value: 2 },
+            { value: 3 },
+            { value: 4 },
+          ],
+        },
+      });
+
+      const getNextState = () => ({
+        foo: {
+          bar: [
+            { value: 1 },
+            { value: 2 },
+            { value: 4 },
+          ],
+        },
+      });
+
+      const nextDispatch = action => {
+        done(assert.deepEqual(
+          action.value,
+          [
+            { value: 1 },
+            { value: 2 },
+          ]));
+      };
+
+      const dispatch = action => {
+        assert.deepEqual(
+          action.value,
+          [
+            { value: 1 },
+            { value: 2 },
+            { value: 4 },
+          ]);
+
+        actions.remove('foo.bar', 2)(nextDispatch, getNextState);
+      };
+
+      actions.remove('foo.bar', 2)(dispatch, getState);
+    });
   });
 
   describe('actions.move() thunk', () => {