Fixing textarea onUpdate="blur" change triggered on enter key. Fixes #930

Author: davidkpiano

src/components/control-component.js

@@ -102,6 +102,7 @@ const propTypes = {
   persist: PropTypes.bool,
   getValue: PropTypes.func,
   isToggle: PropTypes.bool,
+  updateOnEnter: PropTypes.bool,
 
   // HTML5 attributes
   formNoValidate: PropTypes.bool,
@@ -440,11 +441,12 @@ function createControlClass(s = defaultStrategy) {
     handleKeyPress(event) {
       const {
         controlProps: { onKeyPress },
+        updateOnEnter,
       } = this.props;
 
       if (onKeyPress) onKeyPress(event);
 
-      if (event.key === 'Enter') {
+      if (updateOnEnter && event.key === 'Enter') {
         this.forceHandleUpdate(event);
       }
     }
@@ -646,6 +648,7 @@ function createControlClass(s = defaultStrategy) {
     persist: false,
     getValue: _getValue,
     isToggle: false,
+    updateOnEnter: true,
   };
 
   function mapStateToProps(state, props) {
@@ -770,6 +773,7 @@ function createControlClass(s = defaultStrategy) {
       return (
         <ConnectedControl
           component="textarea"
+          updateOnEnter={false}
           {...this.props}
           mapProps={{
             ...controlPropsMap.textarea,

test/control-component-spec.js

@@ -1487,6 +1487,35 @@ Object.keys(testContexts).forEach((testKey) => {
 
         assert.isFalse(store.getState().testForm.foo.valid);
       });
+
+      it('should not change blur-updated textareas upon pressing Enter', () => {
+        const reducer = modelReducer('test');
+        const store = testCreateStore({
+          test: reducer,
+          testForm: formReducer('test'),
+        });
+        const field = TestUtils.renderIntoDocument(
+          <Provider store={store}>
+            <Control.textarea
+              model="test.foo"
+              updateOn="blur"
+            />
+          </Provider>
+        );
+
+        const control = TestUtils.findRenderedDOMComponentWithTag(field, 'textarea');
+
+        control.value = 'testing';
+
+        TestUtils.Simulate.keyPress(control, {
+          key: 'Enter',
+          keyCode: 13,
+          which: 13,
+        });
+
+        assert.isUndefined(
+          get(store.getState().test, 'foo'));
+      });
     });
 
     describe('handling onKeyPress', () => {