Updating form pristine value upon dirty/change of field values. Fixes #464

Author: davidkpiano

src/reducers/form/change-action-reducer.js

@@ -13,7 +13,6 @@ function updateFieldValue(field, action) {
   const { value, removeKeys, silent, model } = action;
 
   const changedFieldProps = {
-    pristine: false,
     validated: false,
     retouched: field.submitted
       ? true

src/reducers/form/set-dirty-action-reducer.js

@@ -1,12 +1,24 @@
 import actionTypes from '../../action-types';
 import updateField from '../../utils/update-field';
+import isPristine from '../../form/is-pristine';
+import updateParentForms from '../../utils/update-parent-forms';
 
 export default function setValidityActionReducer(state, action, localPath) {
-  if (action.type !== actionTypes.SET_DIRTY) {
+  if (action.type !== actionTypes.SET_DIRTY && action.type !== actionTypes.CHANGE) {
     return state;
   }
 
-  return updateField(state, localPath, {
+  if (action.type === actionTypes.CHANGE && action.silent) {
+    return state;
+  }
+
+  const newState = updateField(state, localPath, {
+    pristine: false,
+  }, {
     pristine: false,
   });
+
+  return updateParentForms(newState, localPath, (form) => ({
+    pristine: isPristine(form),
+  }));
 }

test/form-reducer-actions-spec.js

@@ -25,6 +25,9 @@ describe('formReducer() (V1)', () => {
           validated: false,
           value: 'foo',
         },
+        expectedForm: {
+          pristine: false,
+        },
       },
       {
         action: actions.change,
@@ -36,6 +39,9 @@ describe('formReducer() (V1)', () => {
             value: { foo: 'bar' },
           },
         },
+        expectedForm: {
+          pristine: false,
+        },
       },
       {
         action: actions.change,
@@ -47,6 +53,9 @@ describe('formReducer() (V1)', () => {
             value: [1, 2, 3],
           },
         },
+        expectedForm: {
+          pristine: false,
+        },
       },
       {
         action: actions.change,
@@ -56,6 +65,9 @@ describe('formReducer() (V1)', () => {
           value: 'string',
           initialValue: 'string',
         },
+        expectedForm: {
+          pristine: true,
+        },
       },
       {
         action: actions.change,
@@ -65,6 +77,9 @@ describe('formReducer() (V1)', () => {
           value: 42,
           initialValue: 42,
         },
+        expectedForm: {
+          pristine: true,
+        },
       },
       {
         action: actions.change,
@@ -74,6 +89,9 @@ describe('formReducer() (V1)', () => {
           value: { foo: 'bar' },
           initialValue: { foo: 'bar' },
         },
+        expectedForm: {
+          pristine: true,
+        },
       },
     ],
     [actionTypes.FOCUS]: [