Skip to content
This repository was archived by the owner on Aug 23, 2022. It is now read-only.

Commit d92830e

Browse files
committed
Fixing usage of PureComponent. Fixes #903
1 parent 36fbceb commit d92830e

File tree

3 files changed

+5
-14
lines changed

3 files changed

+5
-14
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@
9696
"shallow-compare": "1.2.1"
9797
},
9898
"peerDependencies": {
99-
"react": "^0.14.0 || ^15.0.0 || ^16.0.0",
99+
"react": "^15.3.0 || ^16.0.0",
100100
"react-dom": "^0.14.7 || ^15.0.0 || ^16.0.0",
101101
"react-redux": "^4.0.0 || ^5.0.3",
102102
"redux": "^3.0.0"

src/components/control-component.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -682,7 +682,7 @@ function createControlClass(s = defaultStrategy) {
682682
deepKeys: ['controlProps'],
683683
});
684684
},
685-
})(Control), ['controlProps'], ['mapProps']);
685+
})(Control));
686686

687687
/* eslint-disable react/prop-types */
688688
/* eslint-disable react/no-multi-comp */

src/utils/resolve-model.js

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
1-
import React, { Component, PureComponent } from 'react';
1+
import React, { PureComponent } from 'react';
22
import PropTypes from 'prop-types';
3-
import shallowEqual from './shallow-equal';
4-
5-
const ReactComponent = PureComponent || Component;
63

74
function resolveModel(model, parentModel) {
85
if (parentModel) {
@@ -18,14 +15,8 @@ function resolveModel(model, parentModel) {
1815
return model;
1916
}
2017

21-
export default function wrapWithModelResolver(WrappedComponent, deepKeys = [], omitKeys = []) {
22-
class ResolvedModelWrapper extends ReactComponent {
23-
shouldComponentUpdate(nextProps, nextState, nextContext) {
24-
return !shallowEqual(this.context, nextContext) || !shallowEqual(this.props, nextProps, {
25-
deepKeys,
26-
omitKeys,
27-
});
28-
}
18+
export default function wrapWithModelResolver(WrappedComponent) {
19+
class ResolvedModelWrapper extends PureComponent {
2920
render() {
3021
const { model: parentModel, localStore } = this.context;
3122
const resolvedModel = resolveModel(

0 commit comments

Comments
 (0)