Skip to content

Commit 1b2dd4b

Browse files
committed
TODO check who is using deployment
1 parent 34c23dc commit 1b2dd4b

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/action/TransportDeleteInferenceEndpointAction.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -117,11 +117,7 @@ private void doExecuteForked(
117117

118118
var service = serviceRegistry.getService(unparsedModel.service());
119119
if (service.isPresent()) {
120-
if (service.get().isInClusterService()) {
121-
// check for other models using this deployment
122-
} else {
123-
service.get().stop(request.getInferenceEndpointId(), listener);
124-
}
120+
service.get().stop(, listener);
125121
} else {
126122
listener.onFailure(
127123
new ElasticsearchStatusException(

x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/elasticsearch/BaseElasticsearchInternalService.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,8 +119,9 @@ public void start(Model model, ActionListener<Boolean> finalListener) {
119119
}
120120

121121
@Override
122-
public void stop(String inferenceEntityId, ActionListener<Boolean> listener) {
122+
public void stop(String deploymentId, ActionListener<Boolean> listener) {
123123
// TODO check if other inference endpoints are using this deployment
124+
// // get the model + deployment id and check if configured by deployment id or has a dedicated deployment
124125
var request = new StopTrainedModelDeploymentAction.Request(inferenceEntityId);
125126
request.setForce(true);
126127
client.execute(

0 commit comments

Comments
 (0)