Skip to content

Commit 647737c

Browse files
committed
fix test
1 parent ab1e7e5 commit 647737c

File tree

2 files changed

+6
-22
lines changed

2 files changed

+6
-22
lines changed

x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/elasticsearch/BaseElasticsearchInternalService.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,12 @@ private void preferredVariantFromPlatformArchitecture(ActionListener<PreferredMo
239239
// However, in Elastic cloud ml nodes run on Linux x86
240240
delegate.onResponse(PreferredModelVariant.LINUX_X86_OPTIMIZED);
241241
} else {
242-
delegate.onResponse(PreferredModelVariant.PLATFORM_AGNOSTIC);
242+
boolean homogenous = architectures.size() == 1;
243+
if (homogenous && architectures.iterator().next().equals("linux-x86_64")) {
244+
delegate.onResponse(PreferredModelVariant.LINUX_X86_OPTIMIZED);
245+
} else {
246+
delegate.onResponse(PreferredModelVariant.PLATFORM_AGNOSTIC);
247+
}
243248
}
244249
}),
245250
client,

x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/elasticsearch/ElasticsearchInternalService.java

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -380,14 +380,6 @@ private void elserCase(
380380
defaultModelId
381381
);
382382

383-
if (modelVariantDoesNotMatchArchitecturesAndIsNotPlatformAgnostic(preferredModelVariant, esServiceSettingsBuilder.getModelId())) {
384-
throw new IllegalArgumentException(
385-
"Error parsing request config, model id does not match any models available on this platform. Was ["
386-
+ esServiceSettingsBuilder.getModelId()
387-
+ "]"
388-
);
389-
}
390-
391383
throwIfNotEmptyMap(config, name());
392384
throwIfNotEmptyMap(serviceSettingsMap, name());
393385

@@ -403,19 +395,6 @@ private void elserCase(
403395
);
404396
}
405397

406-
private static boolean modelVariantDoesNotMatchArchitecturesAndIsNotPlatformAgnostic(
407-
PreferredModelVariant preferredModelVariant,
408-
String modelId
409-
) {
410-
return modelId.equals(
411-
selectDefaultModelVariantBasedOnClusterArchitecture(
412-
preferredModelVariant,
413-
MULTILINGUAL_E5_SMALL_MODEL_ID_LINUX_X86,
414-
MULTILINGUAL_E5_SMALL_MODEL_ID
415-
)
416-
);
417-
}
418-
419398
@Override
420399
public Model parsePersistedConfigWithSecrets(
421400
String inferenceEntityId,

0 commit comments

Comments
 (0)