Skip to content

Commit b4fa5ee

Browse files
committed
[ML] Make the Cohere service Model Id field is required (elastic#136017)
1 parent 54940e1 commit b4fa5ee

File tree

3 files changed

+7
-2
lines changed

3 files changed

+7
-2
lines changed

docs/changelog/136017.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
pr: 136017
2+
summary: Cohere service Model Id field is required
3+
area: Machine Learning
4+
type: bug
5+
issues: []

x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/cohere/CohereService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -367,7 +367,7 @@ public static InferenceServiceConfiguration get() {
367367
"The name of the model to use for the inference task."
368368
)
369369
.setLabel("Model ID")
370-
.setRequired(false)
370+
.setRequired(true)
371371
.setSensitive(false)
372372
.setUpdatable(false)
373373
.setType(SettingsConfigurationFieldType.STRING)

x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/cohere/CohereServiceTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1557,7 +1557,7 @@ public void testGetConfiguration() throws Exception {
15571557
"model_id": {
15581558
"description": "The name of the model to use for the inference task.",
15591559
"label": "Model ID",
1560-
"required": false,
1560+
"required": true,
15611561
"sensitive": false,
15621562
"updatable": false,
15631563
"type": "str",

0 commit comments

Comments
 (0)