Skip to content

Commit cac7fe2

Browse files
committed
handle zero models
1 parent 12f0633 commit cac7fe2

File tree

2 files changed

+11
-0
lines changed

2 files changed

+11
-0
lines changed

x-pack/plugin/inference/qa/inference-service-tests/src/javaRestTest/java/org/elasticsearch/xpack/inference/InferenceCrudIT.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
import java.util.stream.Stream;
2525

2626
import static org.hamcrest.Matchers.containsString;
27+
import static org.hamcrest.Matchers.empty;
2728
import static org.hamcrest.Matchers.equalTo;
2829
import static org.hamcrest.Matchers.equalToIgnoringCase;
2930
import static org.hamcrest.Matchers.hasSize;
@@ -326,4 +327,9 @@ public void testSupportedStream() throws Exception {
326327
deleteModel(modelId);
327328
}
328329
}
330+
331+
public void testGetZeroModels() throws IOException {
332+
var models = getModels("_all", TaskType.RERANK);
333+
assertThat(models, empty());
334+
}
329335
}

x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/action/TransportGetInferenceModelAction.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,11 @@ private void getModelsByTaskType(TaskType taskType, ActionListener<GetInferenceM
129129
}
130130

131131
private void parseModels(List<UnparsedModel> unparsedModels, ActionListener<GetInferenceModelAction.Response> listener) {
132+
if (unparsedModels.isEmpty()) {
133+
listener.onResponse(new GetInferenceModelAction.Response(List.of()));
134+
return;
135+
}
136+
132137
var parsedModelsByService = new HashMap<String, List<Model>>();
133138
try {
134139
for (var unparsedModel : unparsedModels) {

0 commit comments

Comments
 (0)